diff options
| author | Mike Pattrick <mkp@redhat.com> | 2022-08-17 11:06:34 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-08-22 13:54:50 +0100 |
| commit | 1100248a5c5ccd57059eb8d02ec077e839a23826 (patch) | |
| tree | 6bcfac735bbbb91184850d66f1db1eccf3d339fe | |
| parent | 5b247d938feaa04e05ac24c2241448fad9132e26 (diff) | |
| download | linux-1100248a5c5ccd57059eb8d02ec077e839a23826.tar.bz2 | |
openvswitch: Fix double reporting of drops in dropwatch
Frames sent to userspace can be reported as dropped in
ovs_dp_process_packet, however, if they are dropped in the netlink code
then netlink_attachskb will report the same frame as dropped.
This patch checks for error codes which indicate that the frame has
already been freed.
Signed-off-by: Mike Pattrick <mkp@redhat.com>
Link: https://bugzilla.redhat.com/show_bug.cgi?id=2109946
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/openvswitch/datapath.c | 13 |
1 files changed, 10 insertions, 3 deletions
diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c index 7e8a39a35627..ca22aa73c6e0 100644 --- a/net/openvswitch/datapath.c +++ b/net/openvswitch/datapath.c @@ -252,10 +252,17 @@ void ovs_dp_process_packet(struct sk_buff *skb, struct sw_flow_key *key) upcall.mru = OVS_CB(skb)->mru; error = ovs_dp_upcall(dp, skb, key, &upcall, 0); - if (unlikely(error)) - kfree_skb(skb); - else + switch (error) { + case 0: + case -EAGAIN: + case -ERESTARTSYS: + case -EINTR: consume_skb(skb); + break; + default: + kfree_skb(skb); + break; + } stats_counter = &stats->n_missed; goto out; } |