diff options
| author | Samuel Cabrero <scabrero@suse.de> | 2020-12-18 10:29:49 +0100 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2020-12-18 07:40:21 -0600 |
| commit | 0bf1bafb17df03fbd0e8b9a086c39e6f24af7193 (patch) | |
| tree | c44e56c9b2b33a35ee274a893fee87d15d88d7a2 | |
| parent | 0f2c66ae5c8d9c6250d97060902eeeaa8a06446c (diff) | |
| download | linux-0bf1bafb17df03fbd0e8b9a086c39e6f24af7193.tar.bz2 | |
cifs: Avoid error pointer dereference
The patch 7d6535b72042: "cifs: Simplify reconnect code when dfs
upcall is enabled" leads to the following static checker warning:
fs/cifs/connect.c:160 reconn_set_next_dfs_target()
error: 'server->hostname' dereferencing possible ERR_PTR()
Avoid dereferencing the error pointer by early returning on error
condition.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Signed-off-by: Steve French <stfrench@microsoft.com>
| -rw-r--r-- | fs/cifs/connect.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 509a41ff56b8..b9df85506938 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -155,6 +155,7 @@ static void reconn_set_next_dfs_target(struct TCP_Server_Info *server, cifs_dbg(FYI, "%s: failed to extract hostname from target: %ld\n", __func__, PTR_ERR(server->hostname)); + return; } rc = reconn_set_ipaddr_from_hostname(server); |