summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArvind Yadav <arvind.yadav.cs@gmail.com>2018-04-25 20:26:14 +0530
committerDavid S. Miller <davem@davemloft.net>2018-04-30 16:09:34 -0400
commit00ad691ab140b54ab9f5de5e74cb994f552e8124 (patch)
tree576e21cceb8802d26a4d3a4e2a116d0440112c6c
parentd3c68d0b4183ddfa05577348a231dd117e6563df (diff)
downloadlinux-00ad691ab140b54ab9f5de5e74cb994f552e8124.tar.bz2
sparc: vio: use put_device() instead of kfree()
Never directly free @dev after calling device_register(), even if it returned an error. Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--arch/sparc/kernel/vio.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/sparc/kernel/vio.c b/arch/sparc/kernel/vio.c
index 1a0fa10cb6b7..32bae68e34c1 100644
--- a/arch/sparc/kernel/vio.c
+++ b/arch/sparc/kernel/vio.c
@@ -403,7 +403,7 @@ static struct vio_dev *vio_create_one(struct mdesc_handle *hp, u64 mp,
if (err) {
printk(KERN_ERR "VIO: Could not register device %s, err=%d\n",
dev_name(&vdev->dev), err);
- kfree(vdev);
+ put_device(&vdev->dev);
return NULL;
}
if (vdev->dp)