summaryrefslogtreecommitdiffstats
path: root/.mailmap
diff options
context:
space:
mode:
authorMaxim Mikityanskiy <maximmi@nvidia.com>2022-05-12 12:18:30 +0300
committerJakub Kicinski <kuba@kernel.org>2022-05-12 10:01:36 -0700
commit3740651bf7e200109dd42d5b2fb22226b26f960a (patch)
tree642623aed22f6d728acd0e129891856c10cdfcac /.mailmap
parent1fa89ffbc04545b7582518e57f4b63e2a062870f (diff)
downloadlinux-3740651bf7e200109dd42d5b2fb22226b26f960a.tar.bz2
tls: Fix context leak on tls_device_down
The commit cited below claims to fix a use-after-free condition after tls_device_down. Apparently, the description wasn't fully accurate. The context stayed alive, but ctx->netdev became NULL, and the offload was torn down without a proper fallback, so a bug was present, but a different kind of bug. Due to misunderstanding of the issue, the original patch dropped the refcount_dec_and_test line for the context to avoid the alleged premature deallocation. That line has to be restored, because it matches the refcount_inc_not_zero from the same function, otherwise the contexts that survived tls_device_down are leaked. This patch fixes the described issue by restoring refcount_dec_and_test. After this change, there is no leak anymore, and the fallback to software kTLS still works. Fixes: c55dcdd435aa ("net/tls: Fix use-after-free after the TLS device goes down and up") Signed-off-by: Maxim Mikityanskiy <maximmi@nvidia.com> Reviewed-by: Tariq Toukan <tariqt@nvidia.com> Link: https://lore.kernel.org/r/20220512091830.678684-1-maximmi@nvidia.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to '.mailmap')
0 files changed, 0 insertions, 0 deletions