summaryrefslogtreecommitdiffstats
path: root/src/smsutil.c
AgeCommit message (Collapse)AuthorFilesLines
2015-09-08smsutil: Do not check the origin portAlfonso Sanchez-Beato1-3/+0
Do not check if the origin port is reserved, as some operators use that range of values.
2015-02-13smsutil: Add additional sanity checkDenis Kenzior1-0/+5
We make sure that after performing the UTF8 -> GSM conversion, the number of GSM bytes is not greater than 11, which is the maximum payload.
2015-02-13sms: Fix alphanumeric TP-OA handlingTommi Kenakkala1-3/+9
TP-OA max length comparisons were incorrect because TP-OA's 7-bit coded octets transport eleven 8-bit chars. The current code assumed only 10 chars were possible. The patch - increases the array size to 23, (maximum of 22 bytes for UTF8 encoding + null terminator) - Updates the sanity check to account for the correct maximum - For encoding, checks the maximum length in UTF8 characters instead of bytes
2013-09-03smsutil: Make sure to return 1/0Denis Kenzior1-1/+1
So the value might be used directly for D-Bus property emission. Otherwise D-Bus asserts and screws itself with: ofonod[7427]: src/sms.c:handle_mwi() process 7427: arguments to dbus_message_iter_append_basic() were incorrect, assertion "*bool_p == 0 || *bool_p == 1" failed in file ../../dbus/dbus-message.c line 2549.
2012-10-01smsutil: Fix warningDenis Kenzior1-1/+1
src/smsutil.c: In function ‘cbs_decode_text’: src/smsutil.c:4116:16: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
2012-09-17smsutil: Fix up style issues from previous commitDenis Kenzior1-4/+3
2012-09-17smsutil: <CR> is not necessarily a CBS padding characterPhilippe Nunes1-2/+12
2012-09-17smsutil: Fix CR padding logic for 7-bit caseDenis Kenzior1-3/+11
2012-09-17smsutil: Fix style issuesPhilippe Nunes1-14/+14
2011-10-10core: Update copyright informationMarcel Holtmann1-1/+1
2011-05-29smsutil: Mark variable properly as unusedMarcel Holtmann1-4/+1
2011-05-27smsutil: Fix missing error handling for strtol functionMarcel Holtmann1-1/+3
2011-03-18smsutil: fix a memory leakBertrand Aygon1-1/+3
This was reported by cppcheck.
2011-02-03smsutil: Fix compilationDenis Kenzior1-2/+2
2011-02-03smsutil: Add alphabet support to encodingAki Niemi1-7/+46
2011-01-28smsutil: do not allow larger file namesLucas De Marchi1-2/+3
If file name had anything in the name after addr-msgid, it would be parsed as well. This is not what we want, since there could be temporary files lying around.
2011-01-28smsutil: Don't bother renaming to the same nameDenis Kenzior1-5/+12
In sms_tx_queue_load, if the resulting file is the same (which is quite often the case) then don't bother trying to rename it.
2011-01-28smsutil: Fix corner case during tx queue loadingDenis Kenzior1-12/+12
If there are extraneous files in the directory when it is being loaded, then the index used to rename the old file into the new file can get out of sync with what the core expects.
2011-01-28smsutil: simplify tx backup loadingDenis Kenzior1-41/+11
glib functions as a rule do not use g_try* variations. They use g_malloc instead, so there's no need to check for out of memory conditions.
2011-01-28sms: restore pending tx messages from backupLucas De Marchi1-0/+181
Based on patch from: Kristen Carlson Accardi <kristen@linux.intel.com>
2011-01-28sms: delete sent sms messages from backupLucas De Marchi1-0/+47
Based on patch from Kristen Carlson Accardi <kristen@linux.intel.com>
2011-01-28sms: store pending tx pdus on diskLucas De Marchi1-0/+29
Based on patch from Kristen Carlson Accardi <kristen@linux.intel.com>
2011-01-12smsutil: M15 coding style fixJeevaka Badrappan1-1/+1
2010-12-08smsutil: Make timezone an optional fieldYang Gu1-1/+10
2010-12-07smsutil: Change the range of time zoneYang Gu1-2/+9
2010-12-07smsutil: Minor style fixDenis Kenzior1-1/+2
2010-12-02smsutil: Fix issue in mwi dcs decodingJeevaka Badrappan1-1/+6
2010-12-02smsutil: Fix uninitialized optional elementsDenis Kenzior1-2/+2
sms_decode was never memsetting the returned structure, so if any optional elements were present in the SMS (e.g. status report) then the structure was not completely initialized.
2010-11-29smsutil: explicitly compare pointers to NULLLucas De Marchi1-22/+17
This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // <smpl> @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // </smpl>
2010-11-22smsutil: coding style fixes - rule M6Jeevaka Badrappan1-19/+19
2010-11-04smsutil: Use entire range of ref / port addressesDenis Kenzior1-12/+12
2010-11-02smsutil: Remove traces of ref_offset variableDenis Kenzior1-6/+2
2010-11-02smsutil: Add sms_datagram_prepareDenis Kenzior1-0/+129
2010-11-02smsutil: Get rid of ref_offset in sms_text_prepareDenis Kenzior1-11/+3
The reason for this parameter has ceased to exist quite a while ago. Namely when the API allowed multiple SMS recipients. We prepared a single set of segments and then reset the to address and reference. We no longer allow multiple recipients and none of this is now needed.
2010-11-02smsutil: Additional sanity checks for decode_sctsDenis Kenzior1-0/+21
2010-09-22smsutil: Reflow the fuzzy matching codeDenis Kenzior1-102/+98
Make a bit more readable
2010-09-22smsutil: add fuzzy address check for status reportPetteri Tikander1-16/+87
2010-09-21Fix multi-line comment style issuesJeevaka Badrappan1-12/+21
2010-09-21smsutil: update SR assembly to use SHA1 msg idsDenis Kenzior1-32/+59
2010-09-14smsutil: Clean up ussd_encodeDenis Kenzior1-6/+4
2010-09-14smsutil: Add USSD encoding functionJeevaka Badrappan1-0/+29
2010-09-10smsutil: use unsigned printf format for msgidPetteri Tikander1-2/+2
2010-09-10smsutil: remove unused parameterPetteri Tikander1-3/+1
2010-09-10smsutil: status_report_expirationPetteri Tikander1-3/+48
2010-09-01smsutil: storing/loading sms status report over rebootPetteri Tikander1-3/+156
2010-09-01smsutil: style fixPetteri Tikander1-1/+2
2010-09-01smsutil: use DECLARE_SMS_ADDR_STRPetteri Tikander1-1/+1
in sms_assembly_backup_free
2010-08-17smsutil: Get rid of pointless memberDenis Kenzior1-1/+0
2010-07-23sms: document use_delivery_reportsInaky Perez-Gonzalez1-0/+3
In function sms_text_prepare
2010-07-23sms: sms_assembly_encode_address export and renameInaky Perez-Gonzalez1-4/+3
The new name better reflects the function's purpose. We need to export it, as for generating unique message naming (for persistence and D-Bus object naming), we'll be using the address.