diff options
| author | Denis Kenzior <denkenz@gmail.com> | 2015-07-28 10:18:26 -0500 |
|---|---|---|
| committer | Denis Kenzior <denkenz@gmail.com> | 2015-07-28 10:18:26 -0500 |
| commit | 8be02456649f5a26771f70754659fafd5039efe9 (patch) | |
| tree | 2dc1c3e42108d0a4cf7207963cc484f3e34e097d /src | |
| parent | ca105f704051604053b4c5f6895284733cb10a0b (diff) | |
| download | ofono-8be02456649f5a26771f70754659fafd5039efe9.tar.bz2 | |
cdma-connman: Make static analysis tools happy
The kernel simply puts a null terminator at index 15 prior to ifr_name
processing. So we do the same.
Original report by:
Sabas Rosales, Blanca E <blanca.e.sabas.rosales@intel.com>
Buffer not null terminated (BUFFER_SIZE_WARNING) buffer_size_warning:
Calling strncpy with a maximum size argument of 16 bytes on destination
array ifr.ifr_ifrn.ifrn_name of size 16 bytes might leave the
destination string unterminated.
92 strncpy(ifr.ifr_name, interface, IFNAMSIZ);
Diffstat (limited to 'src')
| -rw-r--r-- | src/cdma-connman.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/cdma-connman.c b/src/cdma-connman.c index 2f2ea54d..cd2a6f76 100644 --- a/src/cdma-connman.c +++ b/src/cdma-connman.c @@ -89,7 +89,7 @@ static void cdma_connman_ifupdown(const char *interface, ofono_bool_t active) return; memset(&ifr, 0, sizeof(ifr)); - strncpy(ifr.ifr_name, interface, IFNAMSIZ); + strncpy(ifr.ifr_name, interface, IFNAMSIZ - 1); if (ioctl(sk, SIOCGIFFLAGS, &ifr) < 0) goto done; |