stk: Fix possible crash

We can't call stk_command_free on a NULL object

1 files changed, 4 insertions, 4 deletions

diff --git a/src/stk.c b/src/stk.c
index e85e595f..209c0bf6 100644
--- a/src/stk.c
+++ b/src/stk.c
@@ -2943,11 +2943,11 @@ void ofono_stk_proactive_command_handled_notify(struct ofono_stk *stk,
 	stk_proactive_command_cancel(stk);
 
 	stk->pending_cmd = stk_command_new_from_pdu(pdu, length);
+	if (stk->pending_cmd == NULL)
+		return;
 
-	if (stk->pending_cmd == NULL ||
-			stk->pending_cmd->status != STK_PARSE_RESULT_OK) {
-		ofono_error("Can't parse proactive command");
-
+	if (stk->pending_cmd->status != STK_PARSE_RESULT_OK) {
+		ofono_error("Can't parse modem-handled proactive command");
 		ok = FALSE;
 		goto out;
 	}