summaryrefslogtreecommitdiffstats
path: root/gdbus
diff options
context:
space:
mode:
authorLuiz Augusto von Dentz <luiz.von.dentz@intel.com>2013-08-19 16:54:35 +0300
committerMarcel Holtmann <marcel@holtmann.org>2013-09-10 19:07:28 -0700
commit778b60a94f12496e18435d62f399b94b243ac206 (patch)
tree69d507bc2502d341105836bcbd66435cc700e402 /gdbus
parent1ad938a5fd9917a9cba46a00a7715f4043723e8a (diff)
downloadofono-778b60a94f12496e18435d62f399b94b243ac206.tar.bz2
gdbus: Fix emitting PropertiesChanged twice
This fixes double emission of PropertiesChanged introduced by flushing changes, the flushing can happen during the pending processing so the pending_prop flag needs to be updated in the beginning and the list of properties can be freed before g_dbus_send_message as it is not required anymore.
Diffstat (limited to 'gdbus')
-rw-r--r--gdbus/object.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/gdbus/object.c b/gdbus/object.c
index c4cf7244..0822fe88 100644
--- a/gdbus/object.c
+++ b/gdbus/object.c
@@ -1642,6 +1642,8 @@ static void process_properties_from_interface(struct generic_data *data,
DBusMessageIter iter, dict, array;
GSList *invalidated;
+ data->pending_prop = FALSE;
+
if (iface->pending_prop == NULL)
return;
@@ -1708,8 +1710,6 @@ static void process_property_changes(struct generic_data *data)
process_properties_from_interface(data, iface);
}
-
- data->pending_prop = FALSE;
}
void g_dbus_emit_property_changed(DBusConnection *connection,