diff options
| author | Denis Kenzior <denkenz@gmail.com> | 2015-07-28 10:16:16 -0500 |
|---|---|---|
| committer | Denis Kenzior <denkenz@gmail.com> | 2015-07-28 10:16:16 -0500 |
| commit | ca105f704051604053b4c5f6895284733cb10a0b (patch) | |
| tree | d6d1bbc5fc725988eb33ee654e7b3af5ecbde491 /gatchat | |
| parent | dbb3ec13e550e20eb96c3958058ad89b3100a169 (diff) | |
| download | ofono-ca105f704051604053b4c5f6895284733cb10a0b.tar.bz2 | |
ppp_net: Make static analysis tools happy
The kernel simply puts a null terminator at index 15 prior to ifr_name
processing. So we do the same.
Original report by:
Sabas Rosales, Blanca E <blanca.e.sabas.rosales@intel.com>
Buffer not null terminated (BUFFER_SIZE_WARNING) buffer_size_warning:
Calling strncpy with a maximum size argument of 16 bytes on destination
array ifr.ifr_ifrn.ifrn_name of size 16 bytes might leave the
destination string unterminated.
67 strncpy(ifr.ifr_name, net->if_name, sizeof(ifr.ifr_name));
Diffstat (limited to 'gatchat')
| -rw-r--r-- | gatchat/ppp_net.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gatchat/ppp_net.c b/gatchat/ppp_net.c index 914ca537..b35dcd17 100644 --- a/gatchat/ppp_net.c +++ b/gatchat/ppp_net.c @@ -64,7 +64,7 @@ gboolean ppp_net_set_mtu(struct ppp_net *net, guint16 mtu) return FALSE; memset(&ifr, 0, sizeof(ifr)); - strncpy(ifr.ifr_name, net->if_name, sizeof(ifr.ifr_name)); + strncpy(ifr.ifr_name, net->if_name, IFNAMSIZ - 1); ifr.ifr_mtu = mtu; err = ioctl(sk, SIOCSIFMTU, (void *) &ifr); |