diff options
| author | Kristen Carlson Accardi <kristen@linux.intel.com> | 2010-04-12 07:38:51 -0700 |
|---|---|---|
| committer | Denis Kenzior <denkenz@gmail.com> | 2010-04-13 15:32:35 -0500 |
| commit | 9c3631f24e496cbeb1235e443ff1fc5014356511 (patch) | |
| tree | d667a179518b507d8ace74cfec73ef83f7796cf5 /gatchat/ppp_cp.c | |
| parent | 0aaf98a35432cce0115d43c69ffd7f25d2892bda (diff) | |
| download | ofono-9c3631f24e496cbeb1235e443ff1fc5014356511.tar.bz2 | |
ppp: remove references to magic number
We will not support loopback detection.
Diffstat (limited to 'gatchat/ppp_cp.c')
| -rw-r--r-- | gatchat/ppp_cp.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/gatchat/ppp_cp.c b/gatchat/ppp_cp.c index 8cbb64f4..6cd36817 100644 --- a/gatchat/ppp_cp.c +++ b/gatchat/ppp_cp.c @@ -583,7 +583,7 @@ static void pppcp_send_echo_reply(struct pppcp_data *data, */ packet->identifier = header->identifier; - /* magic number? */ + /* magic number will always be zero */ ppp_transmit(data->ppp, pppcp_to_ppp_packet(packet), ntohs(packet->length)); @@ -860,6 +860,12 @@ static guint8 pppcp_process_protocol_reject(struct pppcp_data *data, return RXJ_MINUS; } +/* + * For Echo-Request, Echo-Reply, and Discard-Request, we will not + * bother checking the magic number of the packet, because we will + * never send an echo or discard request. We can't reliably detect + * loop back anyway, since we don't negotiate a magic number. + */ static guint8 pppcp_process_echo_request(struct pppcp_data *data, struct pppcp_packet *packet) { |