diff options
| author | Denis Kenzior <denkenz@gmail.com> | 2010-02-05 12:00:14 -0600 |
|---|---|---|
| committer | Denis Kenzior <denkenz@gmail.com> | 2010-02-05 12:00:14 -0600 |
| commit | d223243913fab44322892148ad7d2651de3364d5 (patch) | |
| tree | a4615e3d3a7d7bc31c8b120d1df67ec0887c1cf6 | |
| parent | 1721f81fe93919b7b9fdee85bd105b9c4ebf48f3 (diff) | |
| download | ofono-d223243913fab44322892148ad7d2651de3364d5.tar.bz2 | |
Fix: Use snprintf instead of sprintf in HFP
| -rw-r--r-- | drivers/hfpmodem/voicecall.c | 8 | ||||
| -rw-r--r-- | plugins/hfp.c | 2 |
2 files changed, 5 insertions, 5 deletions
diff --git a/drivers/hfpmodem/voicecall.c b/drivers/hfpmodem/voicecall.c index f8dbeddf..71866d84 100644 --- a/drivers/hfpmodem/voicecall.c +++ b/drivers/hfpmodem/voicecall.c @@ -374,9 +374,9 @@ static void hfp_dial(struct ofono_voicecall *vc, cbd->user = vc; if (ph->type == 145) - sprintf(buf, "ATD+%s", ph->number); + snprintf(buf, sizeof(buf), "ATD+%s", ph->number); else - sprintf(buf, "ATD%s", ph->number); + snprintf(buf, sizeof(buf), "ATD%s", ph->number); if ((clir != OFONO_CLIR_OPTION_DEFAULT) || (cug != OFONO_CUG_OPTION_DEFAULT)) @@ -526,7 +526,7 @@ static void hfp_release_specific(struct ofono_voicecall *vc, int id, req->data = data; req->id = id; - sprintf(buf, "AT+CHLD=1%d", id); + snprintf(buf, sizeof(buf), "AT+CHLD=1%d", id); if (g_at_chat_send(vd->chat, buf, none_prefix, release_id_cb, req, g_free) > 0) @@ -546,7 +546,7 @@ static void hfp_private_chat(struct ofono_voicecall *vc, int id, char buf[32]; if (vd->ag_mpty_features & AG_CHLD_2x) { - sprintf(buf, "AT+CHLD=2%d", id); + snprintf(buf, sizeof(buf), "AT+CHLD=2%d", id); hfp_template(buf, vc, generic_cb, 0, cb, data); diff --git a/plugins/hfp.c b/plugins/hfp.c index 981b05b2..51f1d9a8 100644 --- a/plugins/hfp.c +++ b/plugins/hfp.c @@ -377,7 +377,7 @@ static int service_level_connection(struct ofono_modem *modem, int fd) if (getenv("OFONO_AT_DEBUG")) g_at_chat_set_debug(chat, hfp_debug, NULL); - sprintf(buf, "AT+BRSF=%d", data->hf_features); + snprintf(buf, sizeof(buf), "AT+BRSF=%d", data->hf_features); g_at_chat_send(chat, buf, brsf_prefix, brsf_cb, modem, NULL); data->chat = chat; |