summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDenis Kenzior <denkenz@gmail.com>2009-08-05 12:44:36 -0500
committerDenis Kenzior <denkenz@gmail.com>2009-08-05 12:45:55 -0500
commit965fc09e6a8555a8d5f41d4b86aca28904d05812 (patch)
tree506ea11f560a5d91d172eacbf635d2b274e3c7cb
parented56d7c58559c0207ee33d2ba651280fcd895906 (diff)
downloadofono-965fc09e6a8555a8d5f41d4b86aca28904d05812.tar.bz2
Don't emit signals for unexposed properties
Signals shouldn't be emitted, but we should still track the information so it can be written to the SIM reliably
-rw-r--r--src/message-waiting.c12
1 files changed, 7 insertions, 5 deletions
diff --git a/src/message-waiting.c b/src/message-waiting.c
index d088404a..e33d374d 100644
--- a/src/message-waiting.c
+++ b/src/message-waiting.c
@@ -331,12 +331,12 @@ static void mw_mwis_read_cb(struct ofono_modem *modem, int ok,
info.message_count) {
memcpy(&mw->messages[i], &info, sizeof(info));
- if (!mw_message_waiting_property_name[i])
- continue;
-
indication = info.indication;
count = info.message_count;
+ if (!mw_message_waiting_property_name[i])
+ continue;
+
ofono_dbus_signal_property_changed(conn, modem->path,
MESSAGE_WAITING_INTERFACE,
mw_message_waiting_property_name[i],
@@ -475,7 +475,8 @@ static void mw_set_indicator(struct ofono_modem *modem, int profile,
indication = present;
mw->messages[type].indication = present;
- ofono_dbus_signal_property_changed(conn, modem->path,
+ if (!mw_message_waiting_property_name[type])
+ ofono_dbus_signal_property_changed(conn, modem->path,
MESSAGE_WAITING_INTERFACE,
mw_message_waiting_property_name[type],
DBUS_TYPE_BOOLEAN, &indication);
@@ -484,7 +485,8 @@ static void mw_set_indicator(struct ofono_modem *modem, int profile,
if (mw->messages[type].message_count != messages) {
mw->messages[type].message_count = messages;
- ofono_dbus_signal_property_changed(conn, modem->path,
+ if (!mw_message_waiting_property_name[type])
+ ofono_dbus_signal_property_changed(conn, modem->path,
MESSAGE_WAITING_INTERFACE,
mw_message_count_property_name[type],
DBUS_TYPE_BYTE, &messages);