summaryrefslogtreecommitdiffstats
path: root/sound/pci/lx6464es/lx_core.c
AgeCommit message (Collapse)AuthorFilesLines
2016-04-15ALSA: lx646es: Fix possible uninitialized variable referenceTakashi Iwai1-1/+1
lx_pipe_state() checks the return value from lx_message_send_atomic() and breaks the loop only when it's a negative value. However, lx_message_send_atomic() may return a positive error code (as the return code from the hardware), and then lx_pipe_state() tries to compare the uninitialized current_state variable. Fix this behavior by checking the positive non-zero error code as well. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
2014-09-15ALSA: lx6464es: Use nonatomic PCM opsTakashi Iwai1-162/+90
Like the other previous changes, this patch for lx6464es takes the same strategy for converting to nonatomic PCM ops: replacing spinlock with mutex, converting the irq tasklet to the threaded irq, and merging the trigger tasklets back to the trigger callback. Signed-off-by: Takashi Iwai <tiwai@suse.de>
2014-04-18ALSA: lx_core: Translate comments from french to englishMaxime Ripard1-11/+11
For some reason, some of the comments were actually in poorly encoded french. Translate them in english like they should have been in the first place. Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
2014-04-18ALSA: lx_core: Remove useless #if 0 .. #endifMaxime Ripard1-6/+0
The code contained in these sections are only dev_dbg calls, that are already removed whenever DEBUG isn't defined. Remove the redundant constructs. Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
2014-04-18ALSA: lx_core: Remove dead codeMaxime Ripard1-4/+0
Some code was never compiled because hidden between an #if 0 .. #endif structure, and even when removing these, it was never actually used elsewhere. Remove it entirely. Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
2014-04-18ALSA: lx_core: Fix dev_dbg typoMaxime Ripard1-1/+1
Commit be4e6d3c0fa0 ("ALSA: lx6464es: Use standard printk helpers") converted the custom printk helpers that were used before to standard dev_* functions. One of the dev_dbg calls had a typo, that was hidden away by an #if 0 .. #endif Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
2014-04-18ALSA: lx_core: Switch to using BIT macroMaxime Ripard1-3/+4
Move to using the BIT macro for a few defines. It also allows to discard the french comment that was saying exactly what the BIT macro is now pointing out. Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
2014-04-18ALSA: lx_core: Remove unused definesMaxime Ripard1-5/+0
Commit f9367f3fbe3c ("ALSA: lx6464es: Remove unused function in pci/lx6464es/lx_core.c") removed the lx_dsp_es_check_pipeline function that was the only user of these defines. Since they're useless now, simply remove them. Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
2014-02-26ALSA: lx6464es: Use standard printk helpersTakashi Iwai1-39/+50
Convert with dev_err() and co from snd_printk(), etc. Signed-off-by: Takashi Iwai <tiwai@suse.de>
2014-02-07ALSA: lx6464es: Remove unused function in pci/lx6464es/lx_core.cRashika Kheria1-84/+0
Remove unused function in pci/lx6464es/lx_core.c. This eliminates the following warning in pci/lx6464es/lx_core.c: sound/pci/lx6464es/lx_core.c:144:5: warning: no previous prototype for ‘lx_plx_mbox_read’ [-Wmissing-prototypes] sound/pci/lx6464es/lx_core.c:172:5: warning: no previous prototype for ‘lx_plx_mbox_write’ [-Wmissing-prototypes] sound/pci/lx6464es/lx_core.c:494:5: warning: no previous prototype for ‘lx_dsp_es_check_pipeline’ [-Wmissing-prototypes] Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>
2013-11-06ALSA: lx6464es: Fix pointer cast compile warningsTakashi Iwai1-2/+2
The warnings are really harmless but annoying. Since they are only about debug prints, and it's at most 32bit DMA, let's just cast to unsigned long. sound/pci/lx6464es/lx6464es.c:457:22: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] sound/pci/lx6464es/lx_core.c:1195:21: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] Signed-off-by: Takashi Iwai <tiwai@suse.de>
2012-12-07ALSA: pci: remove __dev* attributesBill Pemberton1-1/+1
CONFIG_HOTPLUG is going away as an option. As result the __dev* markings will be going away. Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, and __devexit. Signed-off-by: Bill Pemberton <wfp5p@virginia.edu> Signed-off-by: Takashi Iwai <tiwai@suse.de>
2011-11-22ALSA: lx6464es - fix device communication via command busTim Blechmann1-4/+12
commit 6175ddf06b6172046a329e3abfd9c901a43efd2e optimized the mem*io functions that have been used to send commands to the device. these optimizations somehow corrupted the communication with the lx6464es, that resulted the device to be unusable with kernels after 2.6.33. this patch emulates the memcpy_*_io functions via a loop to avoid these problems. Signed-off-by: Tim Blechmann <tim@klingt.org> LKML-Reference: <4ECB5257.4040600@ladisch.de> Cc: <stable@kernel.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>
2011-11-22ALSA: lx6464es - command buffer API cleanupTim Blechmann1-3/+4
the command buffer is only accessed from one file, so we can declare the specific functions as static in that file Signed-off-by: Tim Blechmann <tim@klingt.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>
2011-06-25ALSA: lx6464es - include mac address in device nameTim Blechmann1-7/+7
each device has a unique mac address, which can be used to distinguish multiple devices in the same machine. we therefore include the full mac address in the device shortname and the last 6 bytes in the device id. Signed-off-by: Tim Blechmann <tim@klingt.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>
2010-11-01ALSA: lx6464es - make 1 bit signed bitfield unsignedTim Blechmann1-1/+1
converts a 1 bit signed bitfield to an unsigned. Reported-by: Dr. David Alan Gilbert <linux@treblig.org> Signed-off-by: Tim Blechmann <tim@klingt.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>
2009-09-21ALSA: lx6464es - cleanup of rmh message bus functionTim Blechmann1-97/+1
the rmh bus is not used asynchronously, so it is safe to remove the specific code pieces. Signed-off-by: Tim Blechmann <tim@klingt.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>
2009-04-14ALSA: lx6464es - Disable lx_message_send()Takashi Iwai1-0/+2
Disable lx_message_send() function temporarily as it's not used anywhere. Signed-off-by: Takashi Iwai <tiwai@suse.de>
2009-04-14ALSA: lx6464es - driver for the digigram lx6464es interfaceTim Blechmann1-0/+1442
prototype of a driver for the digigram lx6464es 64 channel ethersound interface. Signed-off-by: Tim Blechmann <tim@klingt.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>
generated by cgit v1.2.3 (git 2.39.1) at 2025-03-19 05:15:52 +0000