summaryrefslogtreecommitdiffstats
path: root/drivers/staging
AgeCommit message (Collapse)AuthorFilesLines
2019-03-20staging: rtl8192u: r8192U_dm: Fix alignment issue.Sanjana Sanikommu1-10/+10
Ajdust alignment to match open paranthesis. Issue found by checkpatch.pl CHECK: Alignment should match open paranthesis. Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-20staging: gasket: Remove return variableNishka Dasgupta1-3/+1
Remove return variable and return the return value directly. Issue suggested by ret.cocci. Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-20staging: greybus: Remove parentheses around variableNishka Dasgupta1-1/+1
Remove parentheses around variable. Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-20staging: erofs: fix parenthesis alignmentJulian Merida6-63/+71
Fix all checkpatch issues: "CHECK: Alignment should match open parenthesis" Signed-off-by: Julian Merida <julianmr97@gmail.com> Reviewed-by: Gao Xiang <gaoxiang25@huawei.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-19staging: fbtft: ternary statement to if statement.Bhagyashri Dighole1-1/+2
Convert a ternary statement into a if statement which is detected while resolving "WARNING: line over 80 characters". Use BIT() macro instead manually left shifting. Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-19staging: mt7621-pci-phy: Add Spaces to Macro DefinitionEmanuel Bennici1-63/+63
Improve Code readability by adding Tabs and Spaces after #define Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-19Staging: rtl8192u: r8180_93cx6.c: Fix space around '<<'.Sanjana Sanikommu1-12/+12
Fix the check as per Linux kernel style for use of spaces. Issue found by checkpatch.pl CHECK:spaces preffered around that '<<' Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-19Staging: rtl8723bs: Add missing NULL check for kmallocMadhumitha Prabakaran1-0/+2
Include missing NULL check for kmalloc in function rtw_init_evt_priv. Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-19Staging: rtl8723bs: Replace NULL comparison with !Madhumitha Prabakaran1-2/+2
Replace NULL comparison with ! in function rtw_init_cmd_priv, to maintain Linux kernel coding style. Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-19Staging: rtl8723bs: Change values to standard error codes in functionsMadhumitha Prabakaran2-5/+5
Change values for standard error codes in functions rtw_init_cmd_priv and rtw_init_evt_priv, as _SUCCESS should be 0 and _FAIL should be -ENOMEM. Also, change the values in corresponding call sites of the functions. Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-19Staging: rtl8723bs: Remove unnecessary local variable in functionMadhumitha Prabakaran1-3/+1
Remove unnecessary local variable 'res' in function and replace the value directly in the return of the function. Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-19staging: rtl8723bs: do not use __constant_cpu_to_le16Sergey Senozhatsky1-2/+2
cpu_to_le16() is capable enough to detect __builtin_constant_p() and to use an appropriate compile time ___constant_swahbXX() function. So we can use cpu_to_le16() instead of __constant_cpu_to_le16(). Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-19staging: ks7010: remove redundant auth_type checkColin Ian King1-9/+7
The range check on auth_type is redundant as there is a prior check on the auth_type values and the only way the block is entered is if auth_type is one of TYPE_PMK1, TYPE_GMK1 and TYPE_GMK2. Hence the auth_type check can be removed. Detected by static analysis with cppcheck. Signed-off-by: Colin Ian King <colin.king@canonical.com> Acked-by: Jeremy Sowden <jeremy@azazel.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-19staging: rtl8188eu: remove unused defines from wifi.hMichael Straube1-110/+0
All defined P2P* in wifi.h are unused in the driver code, so remove them. Signed-off-by: Michael Straube <straube.linux@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18Staging: rtl8188eu: rtw_ieee80211: Fix indent for 'if' statement.Sanjana Sanikommu1-3/+3
Adjust indentation for the condition statement. Issue found by checkpatch.pl WARNING: suspect code indent for condition statements(8,24) Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18Staging: rtl8188eu: core: rtw_mlme.c: Replace NULL comparision.Sanjana Sanikommu1-1/+1
Replace NULL comparison with '!' in the file rtw_mlme.c Issue found by checkpatch.pl semantic patch results for rtw_mlme.c CHECK:Comparision to NULL could be written "!candidate" Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18Staging: gasket: gasket_sysfs.c: Fix string split issue.Sanjana Sanikommu1-6/+3
Concatenate a multi-line string constant into a single line.Issue found by checkpatch.pl. WARNING:quoted string split across line. Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: wlan-ng: line over 80 character limitBranden Bonaby1-2/+2
Align function to prevent it from going over the 80 character a line limit for readability. WARNING: line over 80 characters Signed-off-by: Branden Bonaby <brandonbonaby94@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: speakup: fix printk KERN_LEVEL facility level warningJules Irenge1-2/+2
Replace printk with pr_info to solve checkpatch.pl warning: " WARNING: printk() should include KERN_<LEVEL> facility level" Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18Staging: rtl8188eu: core: rtw_pwrctrl.c: Fix a comparision warning.Sanjana Sanikommu1-1/+1
Move the constant to the right side of comparision. Issue found by checkpatch.pl semantic patch results for rtw_ap.c WARNING:Comparision should place the constant on the right side of the test. Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18Staging: rtl8192e: Remove parentheses around the right hand side of assignmentsBhanusree Pola1-12/+9
Avoid useless parentheses to the right hand side of an assignment. Issue found using coccinelle. The semantic patch that fixes the problem is as follows // <smpl> @r1 disable paren@ expression value,e; @@ ( - value = (e) + value = e ) @r2 depends on r1@ expression value,e; constant c; @@ ( - value = (e == c) + value = (e == c) | - value = (e <= c) + value = (e <= c) | - value = (e >= c) + value = (e >= c) | - value = (e != c) + value = (e != c) ) // </smpl> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: rtl8723bs: Remove Dead Code in core/rtw_mlme.cEmanuel Bennici1-32/+0
The Functions `void rtw_surveydone_event_callback`, `void rtw_indicate_connect`, `void rtw_stadel_event_callback` and `void _rtw_join_timeout_handler` are using the Macro CONFIG_INTEL_WIDI which doesn't exists anymore. Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: rtl8723bs: Remove Dead Functions in os_dep/ioctl_linux.cEmanuel Bennici1-36/+0
The Functions `static int rtw_widi_set()` and `static int rtw_widi_set_probe_request()` part of dead code due to CONFIG_INTEL_WIDI. The fix removes the deadcode. Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: rtl8723bs: Remove Dead Code in os_dep/ioctl_linux.cEmanuel Bennici1-19/+0
Remove Dead Code in `static int rtw_wps_start`, `struct iw_handler rtw_private_handler[]` and `struct iw_priv_args rtw_private_args[]` since they use the Macro CONFIG_INTEL_WIDI witch doesn't exists any more. Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: rtl8723bs: Remove Dead Code in os_dep/os_intfs.cEmanuel Bennici1-12/+0
The Functions `u8 rtw_init_drv_sw` and `u8 rtw_free_drv_sw` uses the Macro CONFIG_INTEL_WIDI witch doesn't exists anymore. This Patch removes those redundant Code Lines. Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: rtl8723bs: Remove Dead Code in os_dep/os_intfs.cEmanuel Bennici1-3/+0
`uint loadparam` uses the Macro CONFIG_INTEL_WIDI witch doesn't exists anymore. Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: rtl8723bs: Remove unreachable Code in core/rtw_cmd.cEmanuel Bennici1-5/+0
The `case INTEl_WIDI_WK_CID`-Statement in Function `u8 rtw_drvextra_cmd_hdl` wouldn't be used because of CONFIG_INTEL_WIDI. Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: rtl8723bs: Remove old unreachable CodeEmanuel Bennici1-5/+0
The commented code in core/rtw_mlme_ext.c obsolete because the macro CONFIG_INTEL_WIDI no longer exists. Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: rtl8723bs: Remove Dead Code in collect_bss_info FunctionEmanuel Bennici1-6/+0
In `u8 collect_bss_info` is a ifdef-Preprocessor who checks CONFIG_INTEL_WIDI, since this Macro doesn't exists anymore this Patch removes the Dead Code in core/rtw_mlme_ext.c Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: rtl8723bs: Remove Dead Include in include/drv_types.hEmanuel Bennici1-4/+0
`rtw_intel_widi.h` is never included due to CONFIG_INTEL_WIDI. This Patch removes the dead code. Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: rtl8723bs: Remove Dead Code in `struct mlme_priv`Emanuel Bennici1-27/+0
Some Lines in the struct mlme_priv are Dead due to CONFIG_INTEL_WIDI. This Fix removes the dead code. Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: gdm724x: Do not break expressionsIgnacio Losiggio1-4/+3
When the entire expression can be shown in the same line breaking it makes it more difficult to read. Signed-off-by: Ignacio Losiggio <iglosiggio@dc.uba.ar> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: rtl8188eu: core: rtw_recv.c: Fix a tab indent issueSanjana Sanikommu1-2/+2
Fix a tab indent issue which removed warnings after compilation using checkpatch.pl. [WARNING]:No extra space at the beginning of a line. Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: rtl8188eu: core: rtw_recv.c: fix a paranthesis issue around pframe ↵Sanjana Sanikommu1-4/+4
-> list in rtw_recv.c Remove unnecessary parathesis issue around '->' . Issue found by checkpatch.pl semantic patch results for rtw_recv.c CHECK: Remove unnecessary paranthesis around pframe -> list Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: rtl8188eu: core: rtw_recv.c: fix a space issueSanjana Sanikommu1-5/+7
Fix a space issue around the below operators mentioned in CHECK. Issue found by checkpatch.pl semantic patch results for rtw_recv.c.. CHECK: spaces preferred around '%' (ctx:VxV) CHECK: spaces preferred around '&' (ctx:VxV) CHECK: spaces preferred around '+' (ctx:VxV) CHECK: spaces preferred around '<<' (ctx:VxV) Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: gasket: gasket_interuppt.c: Fix string split issue.Sanjana Sanikommu1-4/+2
Remove string " across the line. Issue found by checkpatch.pl semantic patch results for rtw_ap.c Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: greybus: remove extern prototypesPayal Kshirsagar1-61/+61
Functions are implicitly declared with "extern". The compiler doesn't need it. extern removed from drivers/staging/greybus/audio_codec.h file. Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: speakup: fix line over 80 characters.Jules Irenge1-2/+8
Fix coding style issues which solves checkpatch.pl warning: "WARNING: line over 80 characters". Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: rtl8188eu: core: rtw_ap.c: Fix multiple blank linesSanjana Sanikommu1-1/+0
Remove multiple blank lines. Issue found by checkpatch.pl semantic patch results for rtw_ap.c CHECK: Please dont use multiple blank lines. Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: mt7621-mmc: Modify the return type of the function msdc_do_commandBhanusree Pola1-8/+8
Modify the return type of the function msdc_do_command to static int as the member error of the structure struct mmc_command is of type int. Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: mt7621-mmc: Fix ret.cooci warningsBhanusree Pola1-3/+1
Return the value directly instead of storing it in local variable err. Remove the unused local variable err. The semantic patch that fixes the first part of the problem is as follows // <smpl> @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; // </smpl> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: rtl8723bs: Change type of variables and return typeMadhumitha Prabakaran2-6/+6
Change type of local variables 'res' and return type of functions 'rtw_init_cmd_pri' and 'rtw_init_evt_priv', as function's return types are defined for standard error codes _SUCCESS and _FAIL. Also, change return type of functions declarations corresponding to change made in function definitions. Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: rtl8723bs: Remove wrapper functions and change function namesMadhumitha Prabakaran3-22/+4
Drop wrappers rtw_init_cmd_priv and rtw_init_evt_priv and remove their function declarations, as their only purpose is to call other functions. Change function names from _rtw_init_cmd_priv to rtw_init_cmd_priv, and _rtw_init_evt_priv to rtw_init_evt_priv in function definitions and function declarations. Also, remove externs in function declarations rtw_init_cmd_priv and rtw_init_evt_priv, to maintain Linux kernel coding style. Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: rtl8723bs: os_dep: Fix space in pointer definitionGuilherme Tadashi Maeoka1-1/+1
Pointer definition "foo * bar" should be "foo *bar". Signed-off-by: Guilherme Tadashi Maeoka <gui.maeoka@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: rtl8723bs: os_dep: Fix assignment in if conditionGuilherme Tadashi Maeoka1-1/+3
Fix an assignment in if condition. Signed-off-by: Guilherme Tadashi Maeoka <gui.maeoka@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: vt6655: rxtx.c: Remove unnecessary space after a castSanjana Sanikommu1-1/+1
Issue found by checkpatch.pl semantic patch results for rxtx.c. Remove unnecessary space after the cast. CHECK: No necessary space is required after a cast. Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: rtl8723bs: remove unused codeColin Ian King1-10/+0
There are two final hunks of code that are only built if SDIO_DYNAMIC_ALLOC_MEM is defined however this is never defined and if it was the code would lead to dereferencing an uninitialized pointer oldmem. It appears that a previous commit 1babeb0c3e59 ("Staging: rtl8723bs: Remove dead code") removed some of the dead code but not all of it. Clean this up by removing the final hunks. Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: rtl8192u: Add required spaces before open parenthesisSidong Yang2-45/+45
Fix error reported by checkpatch.pl Signed-off-by: Sidong Yang <realwakka@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: vc04_services: Use tabs instead of spacesAlejandro Ismael Silva2-73/+73
This patch fixes the checkpatch.pl error: WARNING: please, no spaces at the start of a line in the interface/vchi directory. Signed-off-by: Alejandro Ismael Silva <silva.alejandro.ismael@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-03-18staging: rtl8712 - fix up non-kerneldoc commentsValdis Klētnieks2-3/+3
Building with W=1 reports (among other things) CC [M] drivers/staging/rtl8712/rtl871x_ioctl_linux.o drivers/staging/rtl8712/rtl871x_ioctl_linux.c:1106: warning: Cannot understand * on line 1106 - I thought it was a doc line CC [M] drivers/staging/rtl8712/os_intfs.o drivers/staging/rtl8712/os_intfs.c:366: warning: Cannot understand * on line 366 - I thought it was a doc line drivers/staging/rtl8712/os_intfs.c:434: warning: Cannot understand * on line 434 - I thought it was a doc line Fix up the non-kerneldoc comments Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-25 17:35:55 +0000