summaryrefslogtreecommitdiffstats
path: root/drivers/staging/rtl8192u
AgeCommit message (Collapse)AuthorFilesLines
2013-10-28staging: rtl8192u: use memdup_user to simplify codeTeodora Baluta2-16/+6
Use memdup_user rather than duplicating its implementation. Fix the following coccinelle warnings: drivers/staging/rtl8192u/r8192U_core.c:3792:7-14: WARNING opportunity for memdup_user drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:3153:9-16: WARNING opportunity for memdup_user Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-19staging: rtl8192u: fix sparse warning, make a function staticTeodora Baluta1-2/+2
Fix the following sparse warning: drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c:240:22: warning: symbol 'ieee80211_alloc_txb' was not declared. Should it be static? Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-16Staging: rtl8192u: use gfp_t instead of intTeodora Baluta1-1/+1
This patch fixes the following type of sparse warnings: drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c:247:17: warning: incorrect type in argument 2 (different base types) drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c:247:17: expected restricted gfp_t [usertype] flags drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c:247:17: got int [signed] gfp_mask Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-16Staging: rtl8192u: fix functions that should not be declared externTeodora Baluta2-3/+3
These functions are already marked extern in the header file drivers/staging/rtl8192u/r819xU_phy.c:1716:13: warning: function 'InitialGainOperateWorkItemCallBack' with external linkage has definition drivers/staging/rtl8192u/r819xU_cmdpkt.c:497:12: warning: function 'cmpk_message_handle_rx' with external linkage has definition Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-16Staging: rtl8192u: fix checkpatch.pl errorTeodora Baluta1-1/+2
This patch fixes the checkpatch.pl script error: ERROR: do not use C99 // comments +static long ieee80211_translate_todbm(u8 signal_strength_index)// 0-100 index. Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-16Staging: rtl8192u: fix sparse warnings for static functionsTeodora Baluta5-33/+46
Fix sparse warnings in static function in driver rtl8192u Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-11staging: rtl8192u: copy dot11d.h in ieee80211/dot11d.h and remove itXenia Ragiadakou2-119/+20
This patch copies the content of dot11d.h into ieee80211/dot11d.h and then removes it because practically the two header files are the same with the difference that in dot11d.h some checkpatch warnings have been corrected. This is done because the duplication of dot11d.h is unnecessary since the structures and functions that defines are used directly only inside ieee80211/. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-11staging: rtl8192u: remove ieee80211_crypt.hXenia Ragiadakou1-86/+0
This patch removes ieee80211_crypt.h because this header file is the same as ieee80211/ieee80211_crypt.h and the structures and functions declared in it are used directly only inside ieee80211/. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-11staging: rtl8192u: remove r8180_pm.c and r8180_pm.hXenia Ragiadakou2-76/+0
This patch removes r8180_pm.h and r8180_pm.c from rtl8192u because they are not used anywhere in the driver. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-11staging: rtl8192u: fix line size in r819xU_HTType.hXenia Ragiadakou1-1/+1
This patch fixes the following checkpatch warning in r819xU_HTType.h: WARNING: line over 80 characters Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-11staging: rtl8192u: add parenthesis around complex macros in r819xU_HTType.hXenia Ragiadakou1-2/+3
This patch fixes the following checkpatch error: ERROR: Macros with complex values should be enclosed in parenthesis Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-11staging: rtl8192u: add space after ',' in r819xU_HTType.hXenia Ragiadakou1-1/+1
This patch fixes the following checkpatch error: ERROR: space required after that ',' Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-11staging: rtl8192u: fix alignment in r819xU_HTType.hXenia Ragiadakou1-87/+87
This patch fixes some alignment issues in r819xU_HTType.h to impreove code readability. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-11staging: rtl8192u: fix comments in r819xU_HTType.hXenia Ragiadakou1-103/+91
This patch fixes comments in r819xU_HTType.h by: * replacing // commments with /* */ comments * removing author and date information from comments * removing unnecessary comments This is done to improve code readability. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-11staging: rtl8192u: fix space around braces in r819xU_HTType.hXenia Ragiadakou1-31/+31
This patch fixes the white space around braces in r819xU_HTType.h according to the linux kernel coding style. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-11staging: rtl8192u: use __packed instead of __attribute__((packed))Xenia Ragiadakou3-5/+5
This patch fixes the following checkpatch warning: WARNING: __packed is preferred over __attribute__((packed)) Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-11staging: rtl8192u: fix open brace position in r819xU_cmdpkt.hXenia Ragiadakou1-3/+2
This patch fixes the following checkpatch warning and error: WARNING: missing space after enum definition ERROR: open brace '{' following enum go on the same line Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-11staging: rtl8192u: fix alignment in r819xU_cmdpkt.hXenia Ragiadakou1-6/+6
This patch fixes alignment issues in r819xU_cmdpkt.h to improve code readability. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-11staging: rtl8192u: fix space after ( in r819xU_cmdpkt.hXenia Ragiadakou1-1/+1
This patch removes prohibited space after ( in r819xU_cmdpkt.h according to the linux kernel coding style convention. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-11staging: rtl8192u: fix space at the start of lines in r819xU_cmdpkt.hXenia Ragiadakou1-9/+9
This patch fixes the following checkpatch warning: WARNING: please, no spaces at the start of a line Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-11staging: rtl8192u: fix comments in r819xU_cmdpkt.hXenia Ragiadakou1-91/+82
This patch fixes the comments in r819xU_cmdpkt.h by: * removing any empty or unnecessary comments * replacing the // comments with /* */ comments * removing date and author information from comments This is done to improve code readability and to conform to linux kernel coding style. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-11staging: rtl8192u: fix line size in r819xU_cmdpkt.hXenia Ragiadakou1-13/+15
This patch reduces the line length below 80 chars to improve code readability. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-11staging: rtl8192u: add space after } and , in r819xU_cmdpkt.hXenia Ragiadakou1-8/+8
This patch fixes white space after } and , so that the code becomes more readable and conforms to the linux kernel coding style. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-11staging: rtl8192u: remove #ifdef JOHN_Xenia Ragiadakou3-223/+1
This patch removes the guards #ifdef JOHN_HWSEC, #ifdef JOHN_DUMP_TXDESC and because the code inside them calls some undefined functions (e.g read_rtl8225, rtl8187_read_phy etc). Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-11staging: rtl8192u: Use NULL instead of 0Sachin Kamat1-1/+1
Use NULL instead of 0 for pointer. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-09-29Merge 3.12-rc3 into staging-nextGreg Kroah-Hartman1-0/+2
We want the staging fixes in here as well. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-09-25Staging: rtl8192u: r819xU_cmdpkt: checking NULL value after doing dev_alloc_skbIker Pedrosa1-0/+2
Checking the return of dev_alloc_skb as stated in the following bug: https://bugzilla.kernel.org/show_bug.cgi?id=60411 Signed-off-by: Iker Pedrosa <ikerpedrosam@gmail.com> Reported-by: RUC_Soft_Sec rucsoftsec@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-09-25staging: rt8192u: remove #ifdef RTL8192U in r8192U.hXenia Ragiadakou1-4/+0
This patch removes #ifdef RTL8192U header guard and the code that falls outside it, since RTL8192U is defined. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-09-25staging: rtl8192u: remove code inside #ifdef RTL8190P in r8190_rtl8256.hXenia Ragiadakou1-4/+0
This patch removes the unused code inside #ifdef RTL8190P header guard, since RTL8190P is not defined. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-09-25staging: rtl8192u: remove #ifndef RTL8192U and the code inside itXenia Ragiadakou1-8/+0
This patch removes the unused code inside #ifndef RTL8192U header guard and the guard itself, since RTL8192U is defined. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-09-25staging: rtl8192u: remove #ifndef RTL8190P guard from r8192U_dm.cXenia Ragiadakou1-6/+0
This patch removes #ifndef RTL8190P header guard since RTL8190P is not defined anywhere in rtl8192u code. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-09-25staging: rtl8192u: remove code inside #ifdef RTL8190P in r8192U_dm.cXenia Ragiadakou1-125/+12
This patch removes the unused code that resides inside #ifdef RTL8190P header guard since RTL8190P is not defined. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-09-25staging: rtl8192u: remove code inside #ifdef RTL8190P in r819xU_firmware.cXenia Ragiadakou1-15/+0
This patch removes the unused code that resides inside #ifdef RTL8190P since RTL8190P is not defined. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-09-25staging: rtl8192u: remove code inside #ifdef RTL8190P/RTL8192E in r819xU_phy.cXenia Ragiadakou1-6/+0
This patch removes the unused code inside #ifdef RTL8190P and #ifdef RTL8192E guards since RTL8190P and RTL8192E are not defined. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-09-25staging: rtl8192u: remove unused dm_gpio_change_rf_callback()Xenia Ragiadakou1-73/+0
This patch removes dm_gpio_change_rf_callback() because it is not called anywhere and it resides inside an #ifdef RTL8192E guard while RTL8192E is not defined. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-09-25staging: rtl8192u: remove #ifdef RTL8192U guard in r8192U_dm.cXenia Ragiadakou1-4/+0
This patch removes #ifdef RTL8192U header guards from r8192U_dm.c, since RTL8192U is defined in the included r8192U.h header. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-09-25staging: rtl8192u: remove dm_check_rfctrl_gpio()Xenia Ragiadakou1-42/+0
This patch removes dm_check_rfctrl_gpio() because it does nothing when RTL8192U is defined. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-09-25staging: rtl8192u: check dev_alloc_skb() return value in fw_download_code()Xenia Ragiadakou1-0/+2
This patch adds a check whether skb allocation, in fw_download_code(), was successful. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-09-25staging: rtl8192u: remove unused code in fw_download_code()Xenia Ragiadakou1-6/+0
This patch removes the code that resides outside #ifdef RTL8192U, since RTL8192U is defined in r8192U.h and removes, also, the header guard itself. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-09-25staging: rtl8192u: remove cmpk_message_handle_tx()Xenia Ragiadakou3-37/+0
The function cmpk_message_handle_tx() is called only in r8192U_dm.c in two places. The first call resides outside an #ifdef RTL8192U guard, and since RTL8192U is defined this call can be removed. At the other site this function is called, there is no check on its return value. Since cmpk_message_handle_tx() does not do anything else other than returning true, it can be safely removed. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-09-25staging: rtl8192u: remove unused code from cmpk_message_handle_tx()Xenia Ragiadakou1-73/+1
The file r819xU_cmdpkt.c includes header r8192U.h which defines RTL8192U. This patch removes from cmpk_message_handle_tx() the part of the code that is never used because it resides outside the header guard #ifdef RTL8192U. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-08-27staging: Update e-mail address for Andrea MerelloAndrea Merello16-16/+16
A lot of files contain reference to my old e-mail address. Now I'm going not to read mail from it anymore, so update it with my current address everywhere. Signed-off-by: Andrea Merello <andrea.merello@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-31Staging: rtl8192u/ieee80211: add missing single_release()Li Zefan1-1/+2
The debug file is opened with single_open(), but there's no single_release(). Signed-off-by: Li Zefan <lizefan@huawei.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-23staging: rtl8192u: remove unused macros r819xU_cmdpkt.cXenia Ragiadakou1-13/+0
This patch removes CMPK_DEBOUNCE_CNT and CMPK_PRINT() because they are not used anywhere in the driver. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-23staging: rtl8192u: fix line size and identation in r819xU_cmdpkt.cXenia Ragiadakou1-55/+61
This patch limits the line size below 80 characters, when possible, and fixes identation to meet kernel coding style convetions. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-23staging: rtl8192u: remove unnecessary line continuations in r819xU_cmdpkt.cXenia Ragiadakou1-2/+2
This patch fixes the following checkpatch warning: WARNING: Avoid unnecessary line continuations Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-23staging: rtl8192u: fix comments in r819xU_cmdpkt.cXenia Ragiadakou1-127/+125
This patches fixes comments by: - replacing // comments with /**/ comments - removing unnecessary comments (trailing comments with the function name, comments stating date/author when they are placed inside the function definition) - fixing internal alignment Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-23staging: rtl8192u: fix whitespace in r819xU_cmdpkt.cXenia Ragiadakou1-90/+60
This patch fixes whitespaces in r819xU_cmdpkt.c to follow the kernel coding style and to improve code readability. It fixes the spaces around <,=||&&();} and adds or removes tabs to better align variables. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-23staging: rtl8192u: fix braces in r819xU_cmdpkt.cXenia Ragiadakou1-55/+15
This patch fixes the brace position according to the linux kernel coding style and removes unnecessary braces. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-23staging: rtl8192u: remove commented-out code in r819xU_cmdpkt.cXenia Ragiadakou1-40/+2
This patch removes commented-out code and the comments that refer to it to facilitate code review. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-13 08:59:41 +0000