summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2011-04-17netlabel: Fix set-but-unused variables.David S. Miller1-4/+0
The variable 'type_str' is set but unused in netlbl_cipsov4_add(). Just kill it off. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17l2tp: Fix set-but-unused variables.David S. Miller1-1/+2
The variable 'ret' is set but unused in l2tp_nl_register_ops(). This was obviously meant to maintain error codes which are returned to the caller, make it so. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17irda: irproc: Fix set-but-unused variables.David S. Miller1-3/+2
The variable 'd' is set but unused in irda_proc_register(). Just kill it off. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17irda: irlap_event: Fix set-but-unused variables.David S. Miller1-3/+0
The variable 'ret' is set but unused in irlap_state_sclose(). Just kill it off. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17caif: Fix set-but-unused variables.David S. Miller1-9/+2
The variable 'caifdef' is set but unused in modemcmd(). Similarly for 'net' in receive(), and 'res' in caif_device_notify() and caif_exit_net(). Just kill them off. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17bnx2x: Fix set-but-unused variables.David S. Miller1-7/+2
The variable 'rc' is set but unused in bnx2x_timer(). Similarly for 'hc_index_p' in bnx2x_init_sb(), and 'port' in bnx2x_get_hwinfo(). Just kill them off. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17bna: Fix set-but-unused variables.David S. Miller3-30/+4
The variable 'pgoff' is set but unused in bfa_nw_ioc_fwver_get() and bfa_ioc_download_fw(). Similarly for 'cmd_h' in bna_mbox_flush_q and the entirety of bna_rit_mod_uninit() is unused since variables are purely set but no action is made using them. Same for 'bna' in bna_rit_create() and 'ret' in bna_rx_create(). Just kill them off. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17isdn: mISDN: socket: Fix set-but-unused variables.David S. Miller1-0/+3
The variable 'len' is set but unused in data_sock_getsockopt(). The code should use 'len' to validate that the user's socket option is indeed the right size. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17isdn: i4l: isdn_net: Fix set-but-unused variables.David S. Miller1-2/+0
The variable 'unused' is set but unused in isdn_net_ciscohdlck_slarp_in(). Just kill it off. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17isdn: i4l: isdn_common: Fix set-but-unused variables.David S. Miller1-9/+2
The variable 'ch' is set but unused in isdn_capi_rec_hl_msg(). Just kill it off. Similarly for 'chidx' in isdn_ioctl() and 'di' in isdn_capi_rec_hl_msg(). Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17isdn: teles_cs: Fix set-but-unused variables.David S. Miller1-2/+0
The variable 'dev' is set but unused in teles_cs_config(). Just kill it off. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17isdn: l3ni1: Fix set-but-unused variables.David S. Miller1-3/+1
The variable 'cause' is set but unused in ni1up(). Just kill it off. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17isdn: l3dss1: Fix set-but-unused variables.David S. Miller1-3/+1
The variable 'cause' is set but unused in dss1up(). Just kill it off. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17isdn: jade: Fix set-but-unused variables.David S. Miller1-2/+1
The variable 'i' is set but unused in JadeVersion(). Just kill it off. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17isdn: ipacx: Fix set-but-unused variables.David S. Miller1-2/+2
The variable 'cda2_cr' is set but unused in ctrl_complete(). Just kill it off. Keep the cs->readisac() call just in case the register read has side effects. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17isdn: hfc_usb: Fix set-but-unused variables.David S. Miller1-4/+2
The variable 'buf' is set but unused in ctrl_complete(). Just kill it off. Similarly for 'err' in hfc_usb_init(). Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17isdn: elsa_ser: Fix set-but-unused variables.David S. Miller1-2/+1
The variable 'bits' is set but unused in change_speed(). Just kill it off. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17isdn: elsa_cs: Fix set-but-unused variables.David S. Miller1-2/+0
The variable 'dev' is set but unused in elsa_cs_config(). Just kill it off. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17isdn: arcofi: Fix set-but-unused variables.David S. Miller1-3/+1
The variable 'val' is set but unused in send_arcofi(). Just kill it off. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17isdn: hfcsusb: Fix set-but-unused variables.David S. Miller1-4/+1
The variable 'buf' is set but unused in ctrl_complete(). Just kill it off. Similarly for the variable 'err' in setup_hfcsusb(). Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17isdn: hfcpci: Fix set-but-unused variables.David S. Miller1-4/+2
The variable 'total' is set but unused in hfcpci_empty_bfifo(). Just kill it off. Similarly for the variable 'val' in ph_state_nt(). Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17isdn: eicon: Fix set-but-unused variables.David S. Miller2-23/+3
The variable 'best_id' is set but unused in diva_mnt_add_xdi_adapter(). Just kill it off. Similarly for the variable 'CIP' in connect_req(), 'Number' in sig_ind(), 'Info' in dtmf_confirmation() mixer_command() fax_connect_ack_command() fax_edata_ack_command() rtp_connect_b3_res_command() and rtp_connect_b3_res_command(), and 'a' in mixer_indication_coefs_set(), Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17isdn: gigaset: Fix set-but-unused variable.David S. Miller1-5/+0
The variable 'offset' is set but unused in write_iso_tasklet(). Just kill it off. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17atl1c: Fix set-but-unused variable.David S. Miller1-2/+0
The variable 'extra_size' is set but unused in atl1c_configure_tx(). Just kill it off. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17atl1e: Fix set-but-unused variable.David S. Miller1-2/+0
The variable 'tx_ring' is set but unused in atl1e_init_ring_resources(). Just kill it off. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17atlx: Fix set-but-unused variable.David S. Miller1-3/+0
The variable 'tpc' is set but unused in atl1_intr_tx(). Just kill it off. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17bonding: Fix set-but-unused variable.David S. Miller1-2/+0
The variable 'vlan_dev' is set but unused in bond_send_gratuitous_arp(). Just kill it off. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17atm: lec: Fix set-but-unused variables.David S. Miller1-4/+0
The variable 'eth' is set but unused in lec_handle_bridge(). Also, the variable 'priv' is set but unused in lane_module_cleanup(). Just kill them off. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17ax25: Fix set-but-unused variable.David S. Miller1-2/+1
The variable 's' is set but unused in ax25_protocol_release(). Just kill it off. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17econet: Fix set-but-unused variable.David S. Miller1-8/+0
#if 0'd out code for IP handling in aun_data_available() has been commented out since the beginning, which makes the variable "ip" set but not used. Kill it off as well as the stub code. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17decnet: Fix set-but-unused variable.David S. Miller1-2/+1
"next" in dn_rebuild_zone() is set but not actually used, kill it off. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17pktgen: Fix set-but-unused variable.David S. Miller1-2/+0
"iph" in pktgen_output_ipsec() is set but never actually used. Kill it off. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17atm: solos-pci: Fix set-but-unused variable.David S. Miller1-2/+1
This is just a readback to entire completion of a register write, keep the readback but kill the unused variable. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17atm: idt77252: Fix set-but-unused variables.David S. Miller1-48/+4
Two cases here: 1) idt77252_rx_raw() really does not make any use of the extracted PTI field of the atm header. 2) idt77252_collect_stat() only uses the register values in code which has been compiled out by a "NOTDEF" cpp test for more than 10 years. Just kill this NOTDEF code entirely, but keep the register reads in case they have side effects. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17atm: he: Fix undefined sequence points.David S. Miller1-2/+2
GCC complains in these queue index operations because we perform operations of the form: x = some_operation(++x); which is undefined. Replace with: x = some_operation(x + 1); which is well defined and provides the intended operation. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-17atm: eni: Kill set-but-unused variables.David S. Miller1-5/+0
The variable eni_dev is initialized but never subsequently used in these two functions. Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-15net: gianfar: convert to hw_featuresMichał Mirosław3-61/+16
Note: I bet that gfar_set_features() don't really need a full reset. Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-15net: mlx4: convert to hw_featuresMichał Mirosław4-60/+11
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-15net: forcedeth: convert to hw_featuresMichał Mirosław1-52/+26
This also fixes a race around np->txrxctl_bits while changing RXCSUM offload. Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-15net: dm9000: convert to hw_featuresMichał Mirosław1-44/+13
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-15net: spider_net: convert to hw_featuresMichał Mirosław3-36/+7
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-15net: minor cleanup to net_namespace.c.Rob Landley1-8/+4
Inline a small static function that's only ever called from one place. Signed-off-by: Rob Landley <rlandley@parallels.com> Reviewed-by: Jiri Pirko <jpirko@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-15ipv6: RTA_PREFSRC support for ipv6 route source address selectionDaniel Walter5-7/+84
[ipv6] Add support for RTA_PREFSRC This patch allows a user to select the preferred source address for a specific IPv6-Route. It can be set via a netlink message setting RTA_PREFSRC to a valid IPv6 address which must be up on the device the route will be bound to. Signed-off-by: Daniel Walter <dwalter@barracuda.com> Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-15ipv6: ignore looped-back NA while dad is runningDaniel Walter1-3/+4
[ipv6] Ignore looped-back NAs while in Duplicate Address Detection If we send an unsolicited NA shortly after bringing up an IPv6 address, the duplicate address detection algorithm fails and the ip stays in tentative mode forever. This is due a missing check if the NA is looped-back to us. Signed-off-by: Daniel Walter <dwalter@barracuda.com> Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-14rndis_host: Quirky devices are still 'point-to-point'Ben Hutchings1-1/+1
My changes in commit 4d42d417be75d750b82798922b6e775915e11bce were written some time before the introduction of FLAG_POINTTOPOINT, so didn't include that flag in the new driver_info. Change the new driver_info to be consistent. Signed-off-by: Ben Hutchings <ben@decadent.org.uk> Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-14net-bonding: Adding support for throughputs larger than 65536 MbpsDavid Decotigny2-8/+10
This updates the bonding driver to support v2.6.27-rc3 enhancements (b11f8d8c aka. "ethtool: Expand ethtool_cmd.speed to 32 bits") which allow to encode the Mbps link speed on 32-bits (Max 4 Pbps) instead of 16 (Max 65536 Mbps). This patch also attempts to compact struct slave by reordering its fields. Signed-off-by: David Decotigny <decot@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-14net-bonding: Fix minor/cosmetic type inconsistenciesDavid Decotigny2-4/+2
The __get_link_speed() function returns a u16 value which was stored in a u32 local variable. This patch uses the return value directly, thus fixing that minor type consistency. The 'duplex' field in struct slave being encoded on 8 bits, to be more consistent we use a u8 integer (instead of u16) whenever we copy it to local variables. Signed-off-by: David Decotigny <decot@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-14net-bonding: Fix minor sparse complaintsDavid Decotigny3-4/+3
This gets rid of minor sparse complaints: drivers/net/bonding/bond_main.c:4361:4: warning: do-while statement is not a compound statement drivers/net/bonding/bond_main.c:243:12: warning: symbol 'bond_mode_name' was not declared. Should it be static? Signed-off-by: David Decotigny <decot@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-14qlge: make nic_operations struct conststephen hemminger2-3/+3
The struct nic_operations is just function pointers and should be declared const for added security. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Signed-off-by: David S. Miller <davem@davemloft.net>
2011-04-14sfc: make function tables conststephen hemminger13-24/+24
The phy, mac, and board information structures should be const. Since tables contain function pointer this improves security (at least theoretically). Compile tested only. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Acked-by: Ben Hutchings <bhutchings@solarflare.com> Signed-off-by: David S. Miller <davem@davemloft.net>