summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2016-10-16Staging: fwserial: remove unused function fill_unplug_reqBhumika Goyal1-6/+0
The function fill_unplug_req is not used anywhere in the kernel, so remove it. Done using Coccinelle. @r1@ identifier func; type T; @@ static T func(...) { ... } @r@ identifier r1.func; @@ func @delete depends on !r@ identifier r1.func; type r1.T; @@ - static T func(...){...} Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16Staging: fbtft: Fixed open parenthesis alignment checkHarman Kalra1-6/+3
This patch resolves all the following CHECKs caught by checkpatch.pl CHECK: Alignment should match open parenthesis Signed-off-by: Harman Kalra <harman4linux@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16Staging: emxx_udc: constify usb_ep_ops structureBhumika Goyal1-1/+1
Declare the structure usb_ep_ops as constant as it is only stored in the ops field of a usb_ep structure which is a field of a nbu2ss_ep structure. The ops field is of type const struct usb_ep_ops *, so usb_ep_ops structures having this property can be decalared as const. Done using coccinelle: @r1 disable optional_qualifier @ identifier i; position p; @@ static struct usb_ep_ops i@p = {...}; @ok1@ identifier r1.i; position p; struct nbu2ss_ep s; @@ s.ep.ops=&i@p @bad@ position p!={r1.p,ok1.p}; identifier r1.i; @@ i@p @depends on !bad disable optional_qualifier@ identifier r1.i; @@ static +const struct usb_ep_ops i={...}; @depends on !bad disable optional_qualifier@ identifier r1.i; @@ +const struct usb_ep_ops i; File size before: text data bss dec hex filename 16007 376 3720 20103 4e87 drivers/staging/emxx_udc/emxx_udc.o File size after: text data bss dec hex filename 16095 280 3720 20095 4e7f drivers/staging/emxx_udc/emxx_udc.o Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16Staging: emxx_udc: Remove useless type conversionBhumika Goyal1-3/+3
Some type conversions like casting a pointer to a pointer of same type, casting to the original type using addressof(&) operator etc. are not needed. Therefore, remove them. Done using coccinelle: @@ type t; t *p; t a; @@ ( - (t)(a) + a | - (t *)(p) + p | - (t *)(&a) + &a ) Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16Staging: skein: skein_api: Remove useless type conversionBhumika Goyal1-16/+10
Some type conversions like casting a pointer to a pointer of same type, casting to the original type using addressof(&) operator etc. are not needed. Therefore, remove them. Done using coccinelle: @@ type t; t *p; t a; @@ ( - (t)(a) + a | - (t *)(p) + p | - (t *)(&a) + &a ) Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: comedi: Align the * on block commentsJakub Jedelsky3-6/+6
Block comments should align the * on each line as reported by checkpatch Signed-off-by: Jakub Jedelsky <jakub.jedelsky@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: i4l: add blank line after declarationsElizabeth Ferdman3-0/+9
Fix checkpatch error "missing blank line after declarations" to conform to kernel coding style. Signed-off-by: Elizabeth Ferdman <gnudevliz@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: i4l: move open brace to previous lineElizabeth Ferdman1-2/+1
Fix checkpatch error "open brace should be on previous line" since only functions should have their opening brace on a new line. Signed-off-by: Elizabeth Ferdman <gnudevliz@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: dgnc: make find_board_by_major staticBenoit Hiller1-1/+1
Fixes the following sparse warning: drivers/staging/dgnc/dgnc_tty.c:933:19: warning: symbol 'find_board_by_major' was not declared. Should it be static? Signed-off-by: Benoit Hiller <benoit.hiller@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: xd.c: Remove multiple assignmentsWayne Porter1-1/+2
Checkpatch found multiple assignments on one line so move them to their own lines. Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: xd.c: Fix CamelCaseWayne Porter1-18/+18
Covert CamelCase as checkpatch suggests Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: xd.c: Clean up comparison to NULLWayne Porter1-5/+5
Checkpatch recommended changes Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: xd.c: Remove unnecessary parenthesesWayne Porter1-32/+32
Issues found with checkpatch Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: Logical continuation fixesWayne Porter1-13/+13
Checkpatch detected multiple instances of logical continuation warnings Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: Alignment fixWayne Porter1-153/+179
Coding style checks found by checkpatch Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rts5208: xd.h: Alignment fixWayne Porter1-1/+1
Change alignment to match open parenthesis Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16Staging: media: radio-bcm2048: constify v4l2_ioctl_ops structureBhumika Goyal1-1/+1
Declare the structure v4l2_ioctl_ops as const as it is only stored in the ioctl_ops field of video_device structure. As this field is of type const struct v4l2_ioctl_ops *, so v4l2_ioctl_ops structures having this property can also be made const. Done using coccinelle: @r1 disable optional_qualifier @ identifier i; position p; @@ static struct v4l2_ioctl_ops i@p = {...}; @ok1@ identifier r1.i; position p; struct video_device s; @@ s.ioctl_ops=&i@p; @bad@ position p!={r1.p,ok1.p}; identifier r1.i; @@ i@p @depends on !bad disable optional_qualifier@ identifier r1.i; @@ static +const struct v4l2_ioctl_ops i={...}; @depends on !bad disable optional_qualifier@ identifier r1.i; @@ +const struct v4l2_ioctl_ops i; File size before: text data bss dec hex filename 20465 3220 32 23717 5ca5 drivers/staging/media/bcm2048/radio-bcm2048.o File size after: text data bss dec hex filename 21425 2260 32 23717 5ca5 drivers/staging/media/bcm2048/radio-bcm2048.o Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: media: lirc: Format block comments.Elise Lennion1-3/+6
Fix checkpatch warning: WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Elise Lennion <elise.lennion@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: ks7010: Replace header filesSabitha George1-2/+2
This patch replaces inclusion of asm/atomic.h with linux/atomic.h and asm/io.h with linux/io.h to fix checkpatch warning in ks_wlan.h Signed-off-by: Sabitha George <sabitha.george@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16Staging: ks7010: Delete unnecessary return statementMihaela Muraru1-8/+0
This is a patch to ks_hostif.c file that fixes up a checkpatch.pl WARNING: void function return statements are not generally useful. The 'return' statement is not useful here, because it is not necessary to be forced the exit of the function. Signed-off-by: Mihaela Muraru <mihaela.muraru21@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16Staging: ks7010: __packed instedad of __attribute__((packed))Mihaela Muraru1-4/+4
Fix a issue found by checkpatch.pl tool: "WARNING: __packed is preferred over __attribute__((packed))". Replace __attribute__((packed)) with __packed. Signed-off-by: Mihaela Muraru <mihaela.muraru21@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: ks7010: remove unnecessary else statementEbru Akagunduz1-2/+2
This patch removes else statement which is not usefull after a return. Issue found by checkpatch.pl. Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: ks7010: Use printk format specifier for MAC addressesPontus Fuchs2-36/+9
Convert to %pM instead of custom code. Signed-off-by: Pontus Fuchs <pontus.fuchs@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: ks7010: Remove unnecessary castPontus Fuchs1-3/+2
sdio functions takes unsigned int as address. No need to cast. Signed-off-by: Pontus Fuchs <pontus.fuchs@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16Staging: ks7010: fix brace coding style issueMuraru Mihaela1-82/+73
This is a patch to the ks_wlan_net.c file that fixes up a brace coding style warning found by checkpatch.pl tool, by deleting the unnecessary braces for single statement blocks. Signed-off-by: Muraru Mihaela <mihaela.muraru21@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16Staging: ks7010: add blank line after declarationMuraru Mihaela1-0/+4
This patch fixes a coding style WARNING: Missing a blank line after declaration, found by checkpatch.pl. By adding a blank line after declaration of a variable. Signed-off-by: Muraru Mihaela <mihaela.muraru21@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: ks7010: fix checkpatch "space after #ifdef" errorPhilipp Hoefflin1-1/+1
Fix checkpatch "ERROR: exactly one space required after that #ifdef" error in ks_hostif.c. Signed-off-by: Philipp Hoefflin <p.hoefflin@posteo.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: ks7010: reformat makro ps_confirm_wait_inc()Philipp Hoefflin1-4/+5
Reformat the makro ps_confirm_wait_inc() to fix several checkpatch errors and warnings: - ERROR: space required before the open brace '{' - ERROR: space required before the open parenthesis '(' - ERROR: code indent should use tabs where possible - ERROR: space required after that close brace '}' - ERROR: space required before the open parenthesis '(' - WARNING: line over 80 characters - WARNING: please, no spaces at the start of a line Signed-off-by: Philipp Hoefflin <p.hoefflin@posteo.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: ks7010: use tabs for indentationPhilipp Hoefflin1-3/+3
Fix all occurences of checkpatch "ERROR: code indent should use tabs where possible" errors in ks_hostif.c. Signed-off-by: Philipp Hoefflin <p.hoefflin@posteo.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: ks7010: fix "prohibited space" errors reported by checkpatchPhilipp Hoefflin1-4/+4
Fix all occurences of the following checkpatch errors in ks_hostif.c: - ERROR: space prohibited after that '&' (ctx:WxW) - ERROR: space prohibited after that open parenthesis '(' - ERROR: space prohibited before that close parenthesis ')' Signed-off-by: Philipp Hoefflin <p.hoefflin@posteo.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rtl8188eu: core: fixes tabstop alignmentJuliana Rodrigues1-3/+3
Fixes a tabstop alignment checkpatch issue by removing extra blank spaces. Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: rtl8188eu: core: removes unecessary parenthesisJuliana Rodrigues1-34/+34
Removes unecessary parenthesis from rtw_led.c file that were causing checkpatch warnings. Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16Staging: rtl8712: remove unused functionsBhumika Goyal3-33/+0
Remove the functions sleep_schedulable, down_scanned_network, up_scanned_network and get_free_xmit_queue as they are not used anywhere in the kernel. Functions detected using coccinelle but changes done by hand. Script: @initialize:python@ @@ def display(name,p): print(name,p[0].file) @r1@ identifier func; type T; position p; @@ static T func@p(...) { ... } @r@ identifier r1.func; @@ func @script:python depends on !r@ func << r1.func; p << r1.p; @@ display(func,p) Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16Staging: rtl8192e: rtl_core: Constify rtllib_qos_parameters structuresBhumika Goyal1-1/+1
Declare the structure rtllib_qos_parameters as constant as it is only passed as the second argument to the function memcpy. This argument is constant so the fields of rtllib_qos_parameters structure are never modified and hence it can be declared as const. Done using coccinelle: @r1 disable optional_qualifier @ identifier i; position p; @@ static struct rtllib_qos_parameters i@p = {...}; @ok1@ identifier r1.i; position p; expression e1,e2; @@ memcpy(e1,&i@p,e2) @bad@ position p!={r1.p,ok1.p}; identifier r1.i; @@ i@p @depends on !bad disable optional_qualifier@ identifier r1.i; @@ static +const struct rtllib_qos_parameters i={...}; @depends on !bad disable optional_qualifier@ identifier r1.i; @@ +const struct rtllib_qos_parameters i; File size before: text data bss dec hex filename 30910 496 201 31607 7b77 drivers/staging/rtl8192e/rtl8192e/rtl_core.o File size after: text data bss dec hex filename 30942 464 201 31607 7b77 drivers/staging/rtl8192e/rtl8192e/rtl_core.o Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: sm750fb: Replace printk() with pr_info().Elise Lennion1-1/+1
Fix checkpatch warning: WARNING: printk() should include KERN_ facility level New checkpatch warning appears after including KERN_ facility level. Fix checkpatch warning: WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... Signed-off-by: Elise Lennion <elise.lennion@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: android: ion_test: remove extra line per checkpatch.plWayne Porter1-1/+0
Cleanup extra line found by checkpatch.pl Signed-off-by: Wayne Porter <wporter82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wilc1000: Add blank line after variable declarations.Elise Lennion1-0/+1
Fix checkpath warning: WARNING: Missing a blank line after declarations. Signed-off-by: Elise Lennion <elise.lennion@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wilc1000: Format block comment.Elise Lennion1-1/+2
Fix checkpatch warning: WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Elise Lennion <elise.lennion@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: renames ANL_currFC to avoid camelcaseJuliana Rodrigues2-3/+3
Renames the camelcased variable ANL_currFC to anl_curr_fc in order to fix a checkpatch warning. Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: renames ASL_currBSS to avoid camelcaseJuliana Rodrigues2-3/+4
Renames the camelcased variable ASL_currBSS to asl_curr_bss in order to fix a checkpatch warning. Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: renames CQ_currBSS to avoid camelcaseJuliana Rodrigues2-3/+3
Renames the camelcased variable CQ_currBSS to cq_curr_bss in order to fix a checkpatch warning. Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: renames hfa384x_authenticateStation_data to avoid camelcaseJuliana Rodrigues2-2/+2
Renames the camelcased struct hfa384x_authenticateStation_data to hfa384x_authenticate_station_data in order to fix a checkpatch warning. Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: renames hfa384x_AssocStatus to avoid camelcaseJuliana Rodrigues2-3/+3
Renames the camelcased struct hfa384x_AssocStatus to hfa384x_assoc_status in order to fix a checkpatch warning. Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: renames hfa384x_ChInfoResultSub to avoid camelcaseJuliana Rodrigues2-4/+4
Renames the camelcased struct hfa384x_ChInfoResultSub to hfa384x_ch_info_result_sub in order to fix a checkpatch warning. Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: renames hfa384x_scanResultSub to avoid camelcaseJuliana Rodrigues2-3/+3
Renames the camelcased struct hfa384x_scanResultSub to hfa384x_scan_result_sub in order to fix a checkpatch warning. Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: renames hfa384x_JoinRequest_data to avoid camelcaseJuliana Rodrigues2-5/+5
Renames the camelcased struct hfa384x_JoinRequest_data to hfa384x_join_request_data in order to fix a checkpatch warning. Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: renames hfa384x_ScanResult to avoid camelcaseJuliana Rodrigues2-3/+3
Renames the camelcased struct hfa384x_ScanResult to hfa384x_scan_result in order to fix a checkpatch warning. Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: renames hfa384x_CommTallies32 to avoid camelcaseJuliana Rodrigues2-4/+4
Fixes a checkpatch warning by renaming the camelcased struct hfa384x_CommTallies32 to hfa384x_comm_tallies_32. Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: renames hfa384x_InfFrame to avoid camelcaseJuliana Rodrigues3-28/+30
Renames hfa384x_InfFrame to hfa384x_inf_frame in order to fix a checkpatch error caused by camelcase. Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: fixed lines over 80 charactersJuliana Rodrigues1-3/+6
Breaks lines over 80 characters that were causing checkpatch issues. Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
generated by cgit v1.2.3 (git 2.39.1) at 2024-10-19 19:35:13 +0000