diff options
author | Daniel Lezcano <daniel.lezcano@linaro.org> | 2014-01-17 10:04:02 +0100 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2014-02-10 16:17:04 +0100 |
commit | e5fc66119ec97054eefc83f173a7ee9e133c3c3a (patch) | |
tree | e3bdb0ae5b92a625cef73ec37470b5bf7c040931 /usr | |
parent | b4f2ab43615e5b36c48fffa99f26aca381839ac6 (diff) | |
download | linux-e5fc66119ec97054eefc83f173a7ee9e133c3c3a.tar.bz2 |
sched: Fix race in idle_balance()
The scheduler main function 'schedule()' checks if there are no more tasks
on the runqueue. Then it checks if a task should be pulled in the current
runqueue in idle_balance() assuming it will go to idle otherwise.
But idle_balance() releases the rq->lock in order to look up the sched
domains and takes the lock again right after. That opens a window where
another cpu may put a task in our runqueue, so we won't go to idle but
we have filled the idle_stamp, thinking we will.
This patch closes the window by checking if the runqueue has been modified
but without pulling a task after taking the lock again, so we won't go to idle
right after in the __schedule() function.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: alex.shi@linaro.org
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1389949444-14821-2-git-send-email-daniel.lezcano@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'usr')
0 files changed, 0 insertions, 0 deletions