diff options
| author | Steven Rostedt <rostedt@goodmis.org> | 2014-04-22 19:23:30 -0400 |
|---|---|---|
| committer | Jiri Olsa <jolsa@redhat.com> | 2014-04-23 13:19:30 +0200 |
| commit | de04f8657de9d3351a2d5880f1f7080b23b798cf (patch) | |
| tree | 5efce3ca6d2cc24dd901256ab78cddc181bb0829 /tools/lib/traceevent | |
| parent | 4508793541140723ab862d83095f6b5141d24e49 (diff) | |
| download | linux-de04f8657de9d3351a2d5880f1f7080b23b798cf.tar.bz2 | |
tools lib traceevent: Fix memory leak in pretty_print()
Commit 12e55569a244 "tools lib traceevent: Use helper trace-seq in print
functions like kernel does" added a extra trace_seq helper to process
string arguments like the kernel does it. But the difference between the
kernel and the userspace library is that the kernel's trace_seq structure
has a static allocated buffer. The userspace one has a dynamically
allocated one. It requires a trace_seq_destroy(), otherwise it produces
a nasty memory leak.
Cc: stable@vger.kernel.org # 3.14+
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/20140422192330.6bb09bf8@gandalf.local.home
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Diffstat (limited to 'tools/lib/traceevent')
| -rw-r--r-- | tools/lib/traceevent/event-parse.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c index baec7d887da4..b83184f2d484 100644 --- a/tools/lib/traceevent/event-parse.c +++ b/tools/lib/traceevent/event-parse.c @@ -4344,6 +4344,7 @@ static void pretty_print(struct trace_seq *s, void *data, int size, struct event format, len_arg, arg); trace_seq_terminate(&p); trace_seq_puts(s, p.buffer); + trace_seq_destroy(&p); arg = arg->next; break; default: |