diff options
author | Palmer Cox <p@lmercox.com> | 2012-11-27 13:17:45 +0100 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2012-11-27 23:07:19 +0100 |
commit | 53d2000ebe0618219f73ac866701533237180044 (patch) | |
tree | 2e18236f6a0a7b42732c76cb78e962d23c0d9dd8 /tools/firewire | |
parent | fb8eaeb7ab96b09c910e36abf7df7f9ecbb0fb60 (diff) | |
download | linux-53d2000ebe0618219f73ac866701533237180044.tar.bz2 |
cpupower tools: Fix issues with sysfs_topology_read_file
Fix a variety of issues with sysfs_topology_read_file:
* The return value of sysfs_topology_read_file function was not properly
being checked for failure.
* The function was reading int valued sysfs variables and then returning
their value. So, even if a function was trying to check the return value
of this function, a caller would not be able to tell an failure code apart
from reading a negative value. This also conflicted with the comment on the
function which said that a return value of 0 indicated success.
* The function was parsing int valued sysfs values with strtoul instead of
strtol.
* The function was non-static even though it was only used in the
file it was declared in.
Signed-off-by: Palmer Cox <p@lmercox.com>
Signed-off-by: Thomas Renninger <trenn@suse.de>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'tools/firewire')
0 files changed, 0 insertions, 0 deletions