diff options
| author | Navid Emamdoost <navid.emamdoost@gmail.com> | 2019-10-27 16:53:24 -0500 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2019-10-28 13:10:42 +0000 |
| commit | 45c1380358b12bf2d1db20a5874e9544f56b34ab (patch) | |
| tree | 31925d1e18438893bce72a115056cb4e5dc1fb12 /sound | |
| parent | c0a333d842ef67ac04adc72ff79dc1ccc3dca4ed (diff) | |
| download | linux-45c1380358b12bf2d1db20a5874e9544f56b34ab.tar.bz2 | |
ASoC: SOF: ipc: Fix memory leak in sof_set_get_large_ctrl_data
In the implementation of sof_set_get_large_ctrl_data() there is a memory
leak in case an error. Release partdata if sof_get_ctrl_copy_params()
fails.
Fixes: 54d198d5019d ("ASoC: SOF: Propagate sof_get_ctrl_copy_params() error properly")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Link: https://lore.kernel.org/r/20191027215330.12729-1-navid.emamdoost@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/soc/sof/ipc.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/sound/soc/sof/ipc.c b/sound/soc/sof/ipc.c index b2f359d2f7e5..086eeeab8679 100644 --- a/sound/soc/sof/ipc.c +++ b/sound/soc/sof/ipc.c @@ -572,8 +572,10 @@ static int sof_set_get_large_ctrl_data(struct snd_sof_dev *sdev, else err = sof_get_ctrl_copy_params(cdata->type, partdata, cdata, sparams); - if (err < 0) + if (err < 0) { + kfree(partdata); return err; + } msg_bytes = sparams->msg_bytes; pl_size = sparams->pl_size; |