summaryrefslogtreecommitdiffstats
path: root/sound
diff options
context:
space:
mode:
authorNicolin Chen <nicoleotsuka@gmail.com>2016-07-19 15:36:14 -0700
committerMark Brown <broonie@kernel.org>2016-07-21 12:07:59 +0100
commit1708796fc1053eae3dcf648669f552967c210bd2 (patch)
tree6196e7b127deb18e4d1c2b5ca5eeaf969076e3b8 /sound
parent622019373c87e335cf926d30ad26b37b9efb27dc (diff)
downloadlinux-1708796fc1053eae3dcf648669f552967c210bd2.tar.bz2
ASoC: cs53l30: Fix bit shift issue of TDM mode
The TDM mode using PCM format now has two-bit right shift due to the format configuration in the driver. According to Figure 4-13 in the CS53L30 datasheet, using ASP_SCLK_INV = 0 and SHIFT_LEFT = 1 should be the correct combination to create one-bit right shift for the DSP type A format. Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com> Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound')
-rw-r--r--sound/soc/codecs/cs53l30.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c
index fd5502e3aa34..2c0d9c430a8c 100644
--- a/sound/soc/codecs/cs53l30.c
+++ b/sound/soc/codecs/cs53l30.c
@@ -592,8 +592,12 @@ static int cs53l30_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
aspctl1 |= CS53L30_ASP_TDM_PDN;
break;
case SND_SOC_DAIFMT_DSP_A:
- /* Clear TDM_PDN and SHIFT_LEFT, invert SCLK */
- aspcfg |= CS53L30_ASP_SCLK_INV;
+ /*
+ * Clear TDM_PDN to turn on TDM mode; Use ASP_SCLK_INV = 0
+ * with SHIFT_LEFT = 1 combination as Figure 4-13 shows in
+ * the CS53L30 datasheet
+ */
+ aspctl1 |= CS53L30_SHIFT_LEFT;
break;
default:
return -EINVAL;