diff options
author | Arnd Bergmann <arnd@arndb.de> | 2019-03-04 21:30:50 +0100 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2019-03-11 16:34:05 +0000 |
commit | 7d7b25d05ef1c5a1a9320190e1eeb55534847558 (patch) | |
tree | 62cf003f194f3c988e47694468d68c1b0d70fad0 /sound/soc/adi | |
parent | c9fbc1c02ec881c8bb037f87efb706d22589fdab (diff) | |
download | linux-7d7b25d05ef1c5a1a9320190e1eeb55534847558.tar.bz2 |
ASoC: ti: fix davinci_mcasp_probe dependencies
The SND_SOC_DAVINCI_MCASP driver can use either edma or sdma as
a back-end, and it takes the presence of the respective dma engine
drivers in the configuration as an indication to which ones should be
built. However, this is flawed in multiple ways:
- With CONFIG_TI_EDMA=m and CONFIG_SND_SOC_DAVINCI_MCASP=y,
is enabled as =m, and we get a link error:
sound/soc/ti/davinci-mcasp.o: In function `davinci_mcasp_probe':
davinci-mcasp.c:(.text+0x930): undefined reference to `edma_pcm_platform_register'
- When CONFIG_SND_SOC_DAVINCI_MCASP=m has already been selected by
another driver, the same link error appears even if CONFIG_TI_EDMA
is disabled
There are possibly other issues here, but it seems that the only reasonable
solution is to always build both SND_SOC_TI_EDMA_PCM and
SND_SOC_TI_SDMA_PCM as a dependency here. Both are fairly small and
do not have any other compile-time dependencies, so the cost is
very small, and makes the configuration stage much more consistent.
Fixes: f2055e145f29 ("ASoC: ti: Merge davinci and omap directories")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/adi')
0 files changed, 0 insertions, 0 deletions