diff options
author | Yunsheng Lin <linyunsheng@huawei.com> | 2021-08-06 09:39:07 +0800 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2021-08-09 10:03:02 +0100 |
commit | 0fa32ca438b42fadfb293d72690e117ab3d67489 (patch) | |
tree | 90e700c7c4e93410acc9dd0141324467edff945a /sound/sh/aica.h | |
parent | 86aab09a4870bb8346c9579864588c3d7f555299 (diff) | |
download | linux-0fa32ca438b42fadfb293d72690e117ab3d67489.tar.bz2 |
page_pool: mask the page->signature before the checking
As mentioned in commit c07aea3ef4d4 ("mm: add a signature in
struct page"):
"The page->signature field is aliased to page->lru.next and
page->compound_head."
And as the comment in page_is_pfmemalloc():
"lru.next has bit 1 set if the page is allocated from the
pfmemalloc reserves. Callers may simply overwrite it if they
do not need to preserve that information."
The page->signature is OR’ed with PP_SIGNATURE when a page is
allocated in page pool, see __page_pool_alloc_pages_slow(),
and page->signature is checked directly with PP_SIGNATURE in
page_pool_return_skb_page(), which might cause resoure leaking
problem for a page from page pool if bit 1 of lru.next is set
for a pfmemalloc page. What happens here is that the original
pp->signature is OR'ed with PP_SIGNATURE after the allocation
in order to preserve any existing bits(such as the bit 1, used
to indicate a pfmemalloc page), so when those bits are present,
those page is not considered to be from page pool and the DMA
mapping of those pages will be left stale.
As bit 0 is for page->compound_head, So mask both bit 0/1 before
the checking in page_pool_return_skb_page(). And we will return
those pfmemalloc pages back to the page allocator after cleaning
up the DMA mapping.
Fixes: 6a5bcd84e886 ("page_pool: Allow drivers to hint on SKB recycling")
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'sound/sh/aica.h')
0 files changed, 0 insertions, 0 deletions