diff options
| author | Takashi Iwai <tiwai@suse.de> | 2020-02-18 10:14:09 +0100 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2020-02-18 10:15:41 +0100 |
| commit | 44eeb081b8630bb3ad3cd381d1ae1831463e48bb (patch) | |
| tree | 22799f2d7d68e9a71bca72600a38af044232e299 /sound/hda/hdmi_chmap.c | |
| parent | cc5049ae4d457194796f854eb2e38b9727ad8c2d (diff) | |
| download | linux-44eeb081b8630bb3ad3cd381d1ae1831463e48bb.tar.bz2 | |
ALSA: hda: Use scnprintf() for printing texts for sysfs/procfs
Some code in HD-audio driver calls snprintf() in a loop and still
expects that the return value were actually written size, while
snprintf() returns the expected would-be length instead. When the
given buffer limit were small, this leads to a buffer overflow.
Use scnprintf() for addressing those issues. It returns the actually
written size unlike snprintf().
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20200218091409.27162-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/hda/hdmi_chmap.c')
| -rw-r--r-- | sound/hda/hdmi_chmap.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/hda/hdmi_chmap.c b/sound/hda/hdmi_chmap.c index 5fd6d575e123..aad5c4bf4d34 100644 --- a/sound/hda/hdmi_chmap.c +++ b/sound/hda/hdmi_chmap.c @@ -250,7 +250,7 @@ void snd_hdac_print_channel_allocation(int spk_alloc, char *buf, int buflen) for (i = 0, j = 0; i < ARRAY_SIZE(cea_speaker_allocation_names); i++) { if (spk_alloc & (1 << i)) - j += snprintf(buf + j, buflen - j, " %s", + j += scnprintf(buf + j, buflen - j, " %s", cea_speaker_allocation_names[i]); } buf[j] = '\0'; /* necessary when j == 0 */ |