diff options
| author | Takashi Sakamoto <o-takashi@sakamocchi.jp> | 2018-09-13 21:31:18 +0900 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2018-09-13 15:15:39 +0200 |
| commit | 498fe23aad8e3b5a9554f55719c537603b4476ea (patch) | |
| tree | 58a82cc8acb2fa378e4d98575a9e76f0b43f0366 /sound/firewire/oxfw/oxfw.c | |
| parent | 8d28277c065a974873c6781d44b7bcdcd8fb4e8a (diff) | |
| download | linux-498fe23aad8e3b5a9554f55719c537603b4476ea.tar.bz2 | |
ALSA: oxfw: fix memory leak of private data
Although private data of sound card instance is usually allocated in the
tail of the instance, drivers in ALSA firewire stack allocate the private
data before allocating the instance. In this case, the private data
should be released explicitly at .private_free callback of the instance.
This commit fixes memory leak following to the above design.
Fixes: 6c29230e2a5f ('ALSA: oxfw: delayed registration of sound card')
Cc: <stable@vger.kernel.org> # v4.7+
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/firewire/oxfw/oxfw.c')
| -rw-r--r-- | sound/firewire/oxfw/oxfw.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sound/firewire/oxfw/oxfw.c b/sound/firewire/oxfw/oxfw.c index 1e5b2c802635..fd34ef2ac679 100644 --- a/sound/firewire/oxfw/oxfw.c +++ b/sound/firewire/oxfw/oxfw.c @@ -130,6 +130,7 @@ static void oxfw_free(struct snd_oxfw *oxfw) kfree(oxfw->spec); mutex_destroy(&oxfw->mutex); + kfree(oxfw); } /* |