summaryrefslogtreecommitdiffstats
path: root/sound/core
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2019-03-27 16:56:08 +0100
committerTakashi Iwai <tiwai@suse.de>2019-03-27 16:56:08 +0100
commita7588c896b05444929ecb3d0115481988720abf6 (patch)
tree14e736023f0b244cb7846bf67ac661b13667775a /sound/core
parent7bb4a8a2cc9382da720b46988bc976ebccaa49fd (diff)
downloadlinux-a7588c896b05444929ecb3d0115481988720abf6.tar.bz2
ALSA: timer: Check ack_list emptiness instead of bit flag
For checking the pending timer instance that is still left on the timer object that is being closed, we set/clear a bit flag SNDRV_TIMER_IFLG_CALLBACK around the call of callbacks. This can be simplified by replace with the list_empty() call for ti->ack_list. This covers the existence more comprehensively and safely. A gratis bonus is that we can get rid of SNDRV_TIMER_IFLG_CALLBACK bit flag definition as well. Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/core')
-rw-r--r--sound/core/timer.c10
1 files changed, 4 insertions, 6 deletions
diff --git a/sound/core/timer.c b/sound/core/timer.c
index 107d8ebeeb2e..e343de0e4f9e 100644
--- a/sound/core/timer.c
+++ b/sound/core/timer.c
@@ -366,7 +366,7 @@ static int snd_timer_close_locked(struct snd_timer_instance *timeri)
timer->num_instances--;
/* wait, until the active callback is finished */
spin_lock_irq(&timer->lock);
- while (timeri->flags & SNDRV_TIMER_IFLG_CALLBACK) {
+ while (!list_empty(&timeri->ack_list)) {
spin_unlock_irq(&timer->lock);
udelay(10);
spin_lock_irq(&timer->lock);
@@ -731,19 +731,17 @@ static void snd_timer_process_callbacks(struct snd_timer *timer,
ti = list_first_entry(head, struct snd_timer_instance,
ack_list);
- /* remove from ack_list and make empty */
- list_del_init(&ti->ack_list);
-
ticks = ti->pticks;
ti->pticks = 0;
resolution = ti->resolution;
- ti->flags |= SNDRV_TIMER_IFLG_CALLBACK;
spin_unlock(&timer->lock);
if (ti->callback)
ti->callback(ti, resolution, ticks);
spin_lock(&timer->lock);
- ti->flags &= ~SNDRV_TIMER_IFLG_CALLBACK;
+
+ /* remove from ack_list and make empty */
+ list_del_init(&ti->ack_list);
}
}