diff options
| author | Ulf Magnusson <ulfalizer@gmail.com> | 2017-10-08 19:35:44 +0200 |
|---|---|---|
| committer | Masahiro Yamada <yamada.masahiro@socionext.com> | 2018-01-22 00:49:26 +0900 |
| commit | ae7440ef0c8013d68c00dad6900e7cce5311bb1c (patch) | |
| tree | db7b1c09f2a860a317e06a8158fd0a7586676fa9 /scripts | |
| parent | 0724a7c32a54e3e50d28e19e30c59014f61d4e2c (diff) | |
| download | linux-ae7440ef0c8013d68c00dad6900e7cce5311bb1c.tar.bz2 | |
kconfig: Fix automatic menu creation mem leak
expr_trans_compare() always allocates and returns a new expression,
giving the following leak outline:
...
*Allocate*
basedep = expr_trans_compare(basedep, E_UNEQUAL, &symbol_no);
...
for (menu = parent->next; menu; menu = menu->next) {
...
*Copy*
dep2 = expr_copy(basedep);
...
*Free copy*
expr_free(dep2);
}
*basedep lost!*
Fix by freeing 'basedep' after the loop.
Summary from Valgrind on 'menuconfig' (ARCH=x86) before the fix:
LEAK SUMMARY:
definitely lost: 344,376 bytes in 14,349 blocks
...
Summary after the fix:
LEAK SUMMARY:
definitely lost: 44,448 bytes in 1,852 blocks
...
Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Diffstat (limited to 'scripts')
| -rw-r--r-- | scripts/kconfig/menu.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c index 2baebe346de9..5b2415991c3e 100644 --- a/scripts/kconfig/menu.c +++ b/scripts/kconfig/menu.c @@ -440,6 +440,7 @@ void menu_finalize(struct menu *parent) menu->parent = parent; last_menu = menu; } + expr_free(basedep); if (last_menu) { parent->list = parent->next; parent->next = last_menu->next; |