diff options
author | Takashi Iwai <tiwai@suse.de> | 2017-05-24 10:19:45 +0200 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2017-05-24 18:11:08 +0100 |
commit | 4efda5f2130da033aeedc5b3205569893b910de2 (patch) | |
tree | 9a55c0a2d19260fe65c2fb6c2a401bc6a951abca /scripts | |
parent | 2ea659a9ef488125eb46da6eb571de5eae5c43f6 (diff) | |
download | linux-4efda5f2130da033aeedc5b3205569893b910de2.tar.bz2 |
ASoC: Fix use-after-free at card unregistration
soc_cleanup_card_resources() call snd_card_free() at the last of its
procedure. This turned out to lead to a use-after-free.
PCM runtimes have been already removed via soc_remove_pcm_runtimes(),
while it's dereferenced later in soc_pcm_free() called via
snd_card_free().
The fix is simple: just move the snd_card_free() call to the beginning
of the whole procedure. This also gives another benefit: it
guarantees that all operations have been shut down before actually
releasing the resources, which was racy until now.
Reported-and-tested-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: <stable@vger.kernel.org>
Diffstat (limited to 'scripts')
0 files changed, 0 insertions, 0 deletions