diff options
author | Arnd Bergmann <arnd@arndb.de> | 2020-05-27 15:45:06 +0200 |
---|---|---|
committer | Vinod Koul <vkoul@kernel.org> | 2020-06-24 17:41:40 +0530 |
commit | 6153224bef8b218ecf9bf541b6154ff72fc4c54b (patch) | |
tree | 064c44caddd91a8312cfe94a02d16feb969e77cb /samples/uhid | |
parent | 76e242c284521a0129a4c312093fb0ab102b704a (diff) | |
download | linux-6153224bef8b218ecf9bf541b6154ff72fc4c54b.tar.bz2 |
phy: intel: fix enum type mismatch warning
clang points out that a local variable is initialized with
an enum value of the wrong type:
drivers/phy/intel/phy-intel-combo.c:202:34: error: implicit conversion from enumeration type 'enum intel_phy_mode' to different enumeration type 'enum intel_combo_mode' [-Werror,-Wenum-conversion]
enum intel_combo_mode cb_mode = PHY_PCIE_MODE;
~~~~~~~ ^~~~~~~~~~~~~
>From reading the code, it seems that this was not only the
wrong type, but not even supposed to be a code path that can
happen in practice.
Change the code to have no default phy mode but instead return an
error for invalid input.
Fixes: ac0a95a3ea78 ("phy: intel: Add driver support for ComboPhy")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Dilip Kota <eswara.kota@linux.intel.com>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Link: https://lore.kernel.org/r/20200527134518.908624-1-arnd@arndb.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'samples/uhid')
0 files changed, 0 insertions, 0 deletions