summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorVasily Averin <vvs@virtuozzo.com>2019-03-06 14:10:22 +0300
committerDavid S. Miller <davem@davemloft.net>2019-03-06 10:48:31 -0800
commita10674bf2406afc2554f9c7d31b2dc65d6a27fd9 (patch)
tree2053f19e720f295530adc7ae0243394271a7a41e /net
parent7b8376237618e4ddbf71277c8da6b2e0c57f0f70 (diff)
downloadlinux-a10674bf2406afc2554f9c7d31b2dc65d6a27fd9.tar.bz2
tcp: detecting the misuse of .sendpage for Slab objects
sendpage was not designed for processing of the Slab pages, in some situations it can trigger BUG_ON on receiving side. Signed-off-by: Vasily Averin <vvs@virtuozzo.com> Signed-off-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/ipv4/tcp.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index ad07dd71063d..dbb08140cdc9 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -943,6 +943,10 @@ ssize_t do_tcp_sendpages(struct sock *sk, struct page *page, int offset,
ssize_t copied;
long timeo = sock_sndtimeo(sk, flags & MSG_DONTWAIT);
+ if (IS_ENABLED(CONFIG_DEBUG_VM) &&
+ WARN_ONCE(PageSlab(page), "page must not be a Slab one"))
+ return -EINVAL;
+
/* Wait for a connection to finish. One exception is TCP Fast Open
* (passive side) where data is allowed to be sent before a connection
* is fully established.