diff options
| author | Guillaume Nault <gnault@redhat.com> | 2020-05-30 20:49:56 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-06-01 12:01:05 -0700 |
| commit | 4e4f4ce6abf5f6a8df0561776d3a790d60d519d0 (patch) | |
| tree | dcd703397802fc2c6dba22972d856aff40a00e12 /net | |
| parent | 2a67ab99aad078504ded787211351a12717c6e96 (diff) | |
| download | linux-4e4f4ce6abf5f6a8df0561776d3a790d60d519d0.tar.bz2 | |
cls_flower: remove mpls_opts_policy
Compiling with W=1 gives the following warning:
net/sched/cls_flower.c:731:1: warning: ‘mpls_opts_policy’ defined but not used [-Wunused-const-variable=]
The TCA_FLOWER_KEY_MPLS_OPTS contains a list of
TCA_FLOWER_KEY_MPLS_OPTS_LSE. Therefore, the attributes all have the
same type and we can't parse the list with nla_parse*() and have the
attributes validated automatically using an nla_policy.
fl_set_key_mpls_opts() properly verifies that all attributes in the
list are TCA_FLOWER_KEY_MPLS_OPTS_LSE. Then fl_set_key_mpls_lse()
uses nla_parse_nested() on all these attributes, thus verifying that
they have the NLA_F_NESTED flag. So we can safely drop the
mpls_opts_policy.
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Guillaume Nault <gnault@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/sched/cls_flower.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c index 030896eadd11..b2da37286082 100644 --- a/net/sched/cls_flower.c +++ b/net/sched/cls_flower.c @@ -727,11 +727,6 @@ erspan_opt_policy[TCA_FLOWER_KEY_ENC_OPT_ERSPAN_MAX + 1] = { }; static const struct nla_policy -mpls_opts_policy[TCA_FLOWER_KEY_MPLS_OPTS_MAX + 1] = { - [TCA_FLOWER_KEY_MPLS_OPTS_LSE] = { .type = NLA_NESTED }, -}; - -static const struct nla_policy mpls_stack_entry_policy[TCA_FLOWER_KEY_MPLS_OPT_LSE_MAX + 1] = { [TCA_FLOWER_KEY_MPLS_OPT_LSE_DEPTH] = { .type = NLA_U8 }, [TCA_FLOWER_KEY_MPLS_OPT_LSE_TTL] = { .type = NLA_U8 }, |