diff options
author | Eric Dumazet <edumazet@google.com> | 2019-03-14 20:19:47 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2019-03-15 15:42:11 -0700 |
commit | 4477138fa0ae4e1b699786ef0600863ea6e6c61c (patch) | |
tree | 2afb4ee6fa5cb0effd804cd6b406f71fec6b1ed1 /net | |
parent | daa5c4d0167a308306525fd5ab9a5e18e21f4f74 (diff) | |
download | linux-4477138fa0ae4e1b699786ef0600863ea6e6c61c.tar.bz2 |
tun: properly test for IFF_UP
Same reasons than the ones explained in commit 4179cb5a4c92
("vxlan: test dev->flags & IFF_UP before calling netif_rx()")
netif_rx_ni() or napi_gro_frags() must be called under a strict contract.
At device dismantle phase, core networking clears IFF_UP
and flush_all_backlogs() is called after rcu grace period
to make sure no incoming packet might be in a cpu backlog
and still referencing the device.
A similar protocol is used for gro layer.
Most drivers call netif_rx() from their interrupt handler,
and since the interrupts are disabled at device dismantle,
netif_rx() does not have to check dev->flags & IFF_UP
Virtual drivers do not have this guarantee, and must
therefore make the check themselves.
Fixes: 1bd4978a88ac ("tun: honor IFF_UP in tun_get_user()")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions