summaryrefslogtreecommitdiffstats
path: root/net/unix
diff options
context:
space:
mode:
authorHauke Mehrtens <hauke@hauke-m.de>2018-02-12 23:59:51 +0100
committerDavid S. Miller <davem@davemloft.net>2018-02-13 11:23:24 -0500
commitda360299b6734135a5f66d7db458dcc7801c826a (patch)
tree1c339d3495a058cb0eefd099e4cd3ae11dcd0799 /net/unix
parent07a2e1cf398187814b405665b19d36425ec7a962 (diff)
downloadlinux-da360299b6734135a5f66d7db458dcc7801c826a.tar.bz2
uapi/if_ether.h: move __UAPI_DEF_ETHHDR libc define
This fixes a compile problem of some user space applications by not including linux/libc-compat.h in uapi/if_ether.h. linux/libc-compat.h checks which "features" the header files, included from the libc, provide to make the Linux kernel uapi header files only provide no conflicting structures and enums. If a user application mixes kernel headers and libc headers it could happen that linux/libc-compat.h gets included too early where not all other libc headers are included yet. Then the linux/libc-compat.h would not prevent all the redefinitions and we run into compile problems. This patch removes the include of linux/libc-compat.h from uapi/if_ether.h to fix the recently introduced case, but not all as this is more or less impossible. It is no problem to do the check directly in the if_ether.h file and not in libc-compat.h as this does not need any fancy glibc header detection as glibc never provided struct ethhdr and should define __UAPI_DEF_ETHHDR by them self when they will provide this. The following test program did not compile correctly any more: #include <linux/if_ether.h> #include <netinet/in.h> #include <linux/in.h> int main(void) { return 0; } Fixes: 6926e041a892 ("uapi/if_ether.h: prevent redefinition of struct ethhdr") Reported-by: Guillaume Nault <g.nault@alphalink.fr> Cc: <stable@vger.kernel.org> # 4.15 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/unix')
0 files changed, 0 insertions, 0 deletions