diff options
author | Amitoj Kaur Chawla <amitoj1606@gmail.com> | 2016-02-10 00:12:36 +0530 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2016-02-16 15:32:34 -0500 |
commit | 37ace20a3c99c54ebffb4b13671a01adb20926ca (patch) | |
tree | 61cebd374f01c3957f462ce8f5819d15849734e3 /net/tipc | |
parent | 31d035a0d323d34acbab1b9cc250b443c5c02297 (diff) | |
download | linux-37ace20a3c99c54ebffb4b13671a01adb20926ca.tar.bz2 |
dmascc: Return correct error codes
This change has been made with the goal that kernel functions should
return something more descriptive than -1 on failure.
A variable `err` has been introduced for storing error codes.
The return value of kzalloc on failure should return a -1 and not a
-ENOMEM. This was found using Coccinelle. A simplified version of
the semantic patch used is:
//<smpl>
@@
expression *e;
identifier l1;
@@
e = kzalloc(...);
if (e == NULL) {
...
goto l1;
}
l1:
...
return -1
+ -ENOMEM
;
//</smpl
Furthermore, set `err` to -ENOMEM on failure of alloc_netdev(), and to
-ENODEV on failure of register_netdev() and probe_irq_off().
The single call site only checks that the return value is not 0,
hence no change is required at the call site.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/tipc')
0 files changed, 0 insertions, 0 deletions