diff options
author | Cong Wang <xiyou.wangcong@gmail.com> | 2020-10-02 12:13:34 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2020-10-04 14:53:06 -0700 |
commit | 580e4273d7a883ececfefa692c1f96bdbacb99b5 (patch) | |
tree | 094b0f1cde71ff222877ed9f94175f474c387696 /net/tipc/node.c | |
parent | 9a9e77495958c7382b2438bc19746dd3aaaabb8e (diff) | |
download | linux-580e4273d7a883ececfefa692c1f96bdbacb99b5.tar.bz2 |
net_sched: check error pointer in tcf_dump_walker()
Although we take RTNL on dump path, it is possible to
skip RTNL on insertion path. So the following race condition
is possible:
rtnl_lock() // no rtnl lock
mutex_lock(&idrinfo->lock);
// insert ERR_PTR(-EBUSY)
mutex_unlock(&idrinfo->lock);
tc_dump_action()
rtnl_unlock()
So we have to skip those temporary -EBUSY entries on dump path
too.
Reported-and-tested-by: syzbot+b47bc4f247856fb4d9e1@syzkaller.appspotmail.com
Fixes: 0fedc63fadf0 ("net_sched: commit action insertions together")
Cc: Vlad Buslov <vladbu@mellanox.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/tipc/node.c')
0 files changed, 0 insertions, 0 deletions