summaryrefslogtreecommitdiffstats
path: root/net/tipc/link.c
diff options
context:
space:
mode:
authorYing Xue <ying.xue@windriver.com>2014-05-08 08:54:40 +0800
committerDavid S. Miller <davem@davemloft.net>2014-05-09 01:41:01 -0400
commitca9cf06a0654fcf4b114a5a2d08723fc45d00317 (patch)
tree8f08a86ecd8fc2b4fd35dc0ddc5bcec40194b61b /net/tipc/link.c
parentaecb9bb89cbc08366c50a98d2d4751b381a6dc3b (diff)
downloadlinux-ca9cf06a0654fcf4b114a5a2d08723fc45d00317.tar.bz2
tipc: don't directly overwrite node action_flags
Each node action flag should be set or cleared separately, instead we now set the whole flags variable in one shot, and it's turned out to be hard to see which other flags are affected. Therefore, for instance, we explicitly clear TIPC_WAIT_OWN_LINKS_DOWN bit in node_lost_contact(). Signed-off-by: Ying Xue <ying.xue@windriver.com> Reviewed-by: Jon Maloy <jon.maloy@ericsson.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/tipc/link.c')
-rw-r--r--net/tipc/link.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/tipc/link.c b/net/tipc/link.c
index 26abb16e86ab..2140837fbab9 100644
--- a/net/tipc/link.c
+++ b/net/tipc/link.c
@@ -1853,7 +1853,7 @@ static void tipc_link_proto_rcv(struct tipc_link *l_ptr, struct sk_buff *buf)
* peer has lost contact -- don't allow peer's links
* to reactivate before we recognize loss & clean up
*/
- l_ptr->owner->action_flags = TIPC_WAIT_OWN_LINKS_DOWN;
+ l_ptr->owner->action_flags |= TIPC_WAIT_OWN_LINKS_DOWN;
}
link_state_event(l_ptr, RESET_MSG);