diff options
author | Ivan Krylov <krylov.r00t@gmail.com> | 2018-10-14 11:18:03 +0300 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2019-01-04 12:54:49 -0300 |
commit | 442b4eb3af44906fcbb526d98c314b27f8c9acf3 (patch) | |
tree | 7733b87f0816c18fe1b08cf3d03b814c0044e759 /net/tipc/addr.c | |
parent | a3366db06bb656cef2e03f30f780d93059bcc594 (diff) | |
download | linux-442b4eb3af44906fcbb526d98c314b27f8c9acf3.tar.bz2 |
perf annotate: Pass filename to objdump via execl
The symbol__disassemble() function uses shell to launch objdump and
filter its output via grep. Passing filenames by interpolating them into
the command line via "%s" may lead to problems if said filenames contain
special characters.
Instead, pass the filename as a command line argument where it is not
subject to any kind of interpretation, then use quoted shell
interpolation to build the strings we need safely.
Signed-off-by: Ivan Krylov <krylov.r00t@gmail.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20181014111803.5d83b806@Tarkus
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'net/tipc/addr.c')
0 files changed, 0 insertions, 0 deletions