diff options
| author | NeilBrown <neilb@suse.com> | 2017-04-10 12:19:40 +1000 |
|---|---|---|
| committer | Trond Myklebust <trond.myklebust@primarydata.com> | 2017-04-20 13:44:57 -0400 |
| commit | 62b2417e84ba0734d3f4f95a17e6f5f0be54d75a (patch) | |
| tree | f3389ff25d0fa5282531b726a9a9d8d3086374cd /net/sunrpc/sched.c | |
| parent | 518662e0fcb9fa241fe90a337b59bc5066b2a930 (diff) | |
| download | linux-62b2417e84ba0734d3f4f95a17e6f5f0be54d75a.tar.bz2 | |
sunrpc: don't check for failure from mempool_alloc()
When mempool_alloc() is allowed to sleep (GFP_NOIO allows
sleeping) it cannot fail.
So rpc_alloc_task() cannot fail, so rpc_new_task doesn't need
to test for failure.
Consequently rpc_new_task() cannot fail, so the callers
don't need to test.
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Diffstat (limited to 'net/sunrpc/sched.c')
| -rw-r--r-- | net/sunrpc/sched.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/net/sunrpc/sched.c b/net/sunrpc/sched.c index 5db68b371db2..0cc83839c13c 100644 --- a/net/sunrpc/sched.c +++ b/net/sunrpc/sched.c @@ -965,11 +965,6 @@ struct rpc_task *rpc_new_task(const struct rpc_task_setup *setup_data) if (task == NULL) { task = rpc_alloc_task(); - if (task == NULL) { - rpc_release_calldata(setup_data->callback_ops, - setup_data->callback_data); - return ERR_PTR(-ENOMEM); - } flags = RPC_TASK_DYNAMIC; } |