diff options
| author | Ursula Braun <ubraun@linux.ibm.com> | 2018-11-22 10:26:40 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-11-23 17:20:32 -0800 |
| commit | 587e41dcea357a1ac15e3b31d800900e1c585d7e (patch) | |
| tree | 4705cdd8b28076824edfe6a4f1fa7083a9a5a999 /net/smc | |
| parent | 2b59f58e34e78abec2bccd2413ae9e7ea509a855 (diff) | |
| download | linux-587e41dcea357a1ac15e3b31d800900e1c585d7e.tar.bz2 | |
net/smc: cleanup listen worker mutex unlocking
For easier reading move the unlock of mutex smc_create_lgr_pending into
smc_listen_work(), i.e. into the function the mutex has been locked.
No functional change.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Ursula Braun <ubraun@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/smc')
| -rw-r--r-- | net/smc/af_smc.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c index 93f7ff8f6e88..7657e249f526 100644 --- a/net/smc/af_smc.c +++ b/net/smc/af_smc.c @@ -1182,7 +1182,6 @@ static int smc_listen_rdma_finish(struct smc_sock *new_smc, return 0; decline: - mutex_unlock(&smc_create_lgr_pending); smc_listen_decline(new_smc, reason_code, local_contact); return reason_code; } @@ -1282,8 +1281,10 @@ static void smc_listen_work(struct work_struct *work) /* finish worker */ if (!ism_supported) { - if (smc_listen_rdma_finish(new_smc, &cclc, local_contact)) + if (smc_listen_rdma_finish(new_smc, &cclc, local_contact)) { + mutex_unlock(&smc_create_lgr_pending); return; + } } smc_conn_save_peer_info(new_smc, &cclc); mutex_unlock(&smc_create_lgr_pending); |