diff options
| author | Ursula Braun <ubraun@linux.vnet.ibm.com> | 2017-04-10 14:58:01 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-04-11 23:01:14 -0400 |
| commit | 46c28dbd4c23c3f7fa37f5ea48772af79c9cc40e (patch) | |
| tree | 46c18228dafa080d9a7c9ee72edd7ea4f7a6e6b3 /net/smc/smc.h | |
| parent | 90e9517ed9615f9fb23fbef7d279f81e6c5c08b2 (diff) | |
| download | linux-46c28dbd4c23c3f7fa37f5ea48772af79c9cc40e.tar.bz2 | |
net/smc: no socket state changes in tasklet context
Several state changes occur during SMC socket closing. Currently
state changes triggered locally occur in process context with
lock_sock() taken while state changes triggered by peer occur in
tasklet context with bh_lock_sock() taken. bh_lock_sock() does not
wait till a lock_sock(() task in process context is finished. This
may lead to races in socket state transitions resulting in dangling
SMC-sockets, or it may lead to duplicate SMC socket freeing.
This patch introduces a closing worker to run all state changes under
lock_sock().
Signed-off-by: Ursula Braun <ubraun@linux.vnet.ibm.com>
Reviewed-by: Thomas Richter <tmricht@linux.vnet.ibm.com>
Reported-by: Dave Jones <davej@codemonkey.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/smc/smc.h')
| -rw-r--r-- | net/smc/smc.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/smc/smc.h b/net/smc/smc.h index ee5fbea24549..6e44313e4467 100644 --- a/net/smc/smc.h +++ b/net/smc/smc.h @@ -164,6 +164,7 @@ struct smc_connection { #ifndef KERNEL_HAS_ATOMIC64 spinlock_t acurs_lock; /* protect cursors */ #endif + struct work_struct close_work; /* peer sent some closing */ }; struct smc_sock { /* smc sock container */ |