diff options
| author | Wolfgang Grandegger <wg@denx.de> | 2010-01-07 09:43:06 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-01-08 01:02:17 -0800 |
| commit | 2d4b6faf7d1818e9a52ae9f068ab4ffd9c3be923 (patch) | |
| tree | ea83652ec221c38122ac4cc524e365db81b9d4c7 /net/rose | |
| parent | 5856b606e69d3e4dc2d718b475e216eb30ee2006 (diff) | |
| download | linux-2d4b6faf7d1818e9a52ae9f068ab4ffd9c3be923.tar.bz2 | |
can: mscan: fix improper return if dlc < 8 in start_xmit function
The start_xmit function of the MSCAN Driver did return improperly if
the CAN dlc check failed (skb not freed and invalid return code). This
patch adds a proper check of the frame lenght and data size and returns
now correctly. The invalid skb packets are dropped silently as suggested
by David Miller in the thread "[RFC] ndo_validate_skb: Let the netdev
check a valid skb content" on the netdev mailing list.
Furthermore, a typo has been fixed.
Signed-off-by: Wolfgang Grandegger <wg@denx.de>
Reviewed-by: Wolfram Sang <w.sang@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/rose')
0 files changed, 0 insertions, 0 deletions