summaryrefslogtreecommitdiffstats
path: root/net/netrom
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2019-07-22 17:00:01 +0200
committerDavid S. Miller <davem@davemloft.net>2019-07-24 15:45:11 -0700
commit260637903f47f20c5918bb5c1eea52b2a28ea863 (patch)
tree80d4828fc09961777e350163b927cf66cf8c5665 /net/netrom
parent47b79bbb19e1cfc615823ccaac258cdd2c810c47 (diff)
downloadlinux-260637903f47f20c5918bb5c1eea52b2a28ea863.tar.bz2
ovs: datapath: hide clang frame-overflow warnings
Some functions in the datapath code are factored out so that each one has a stack frame smaller than 1024 bytes with gcc. However, when compiling with clang, the functions are inlined more aggressively and combined again so we get net/openvswitch/datapath.c:1124:12: error: stack frame size of 1528 bytes in function 'ovs_flow_cmd_set' [-Werror,-Wframe-larger-than=] Marking both get_flow_actions() and ovs_nla_init_match_and_action() as 'noinline_for_stack' gives us the same behavior that we see with gcc, and no warning. Note that this does not mean we actually use less stack, as the functions call each other, and we still get three copies of the large 'struct sw_flow_key' type on the stack. The comment tells us that this was previously considered safe, presumably since the netlink parsing functions are called with a known backchain that does not also use a lot of stack space. Fixes: 9cc9a5cb176c ("datapath: Avoid using stack larger than 1024.") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/netrom')
0 files changed, 0 insertions, 0 deletions