summaryrefslogtreecommitdiffstats
path: root/net/ipv4/ip_fragment.c
diff options
context:
space:
mode:
authorJann Horn <jannh@google.com>2019-02-06 22:56:15 +0100
committerPablo Neira Ayuso <pablo@netfilter.org>2019-02-11 17:43:17 +0100
commitc4c07b4d6fa1f11880eab8e076d3d060ef3f55fc (patch)
treeba8683c758581ed3dffa2cb5bf58426377cbb179 /net/ipv4/ip_fragment.c
parent31b58ad0c3279817cd246eab27eaf53b626dfcde (diff)
downloadlinux-c4c07b4d6fa1f11880eab8e076d3d060ef3f55fc.tar.bz2
netfilter: nf_nat_snmp_basic: add missing length checks in ASN.1 cbs
The generic ASN.1 decoder infrastructure doesn't guarantee that callbacks will get as much data as they expect; callbacks have to check the `datalen` parameter before looking at `data`. Make sure that snmp_version() and snmp_helper() don't read/write beyond the end of the packet data. (Also move the assignment to `pdata` down below the check to make it clear that it isn't necessarily a pointer we can use before the `datalen` check.) Fixes: cc2d58634e0f ("netfilter: nf_nat_snmp_basic: use asn1 decoder library") Signed-off-by: Jann Horn <jannh@google.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'net/ipv4/ip_fragment.c')
0 files changed, 0 insertions, 0 deletions