diff options
| author | Eric Dumazet <edumazet@google.com> | 2017-12-11 21:25:12 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-12-13 14:33:10 -0500 |
| commit | ec94c2696f0bcd5ae92a553244e4ac30d2171a2d (patch) | |
| tree | 1a9eebba8042da0292f583f778abbe72974cc2a2 /net/dccp/minisocks.c | |
| parent | 1e7570117575360504e632d0c31d6b52d3d7ea9c (diff) | |
| download | linux-ec94c2696f0bcd5ae92a553244e4ac30d2171a2d.tar.bz2 | |
tcp/dccp: avoid one atomic operation for timewait hashdance
First, rename __inet_twsk_hashdance() to inet_twsk_hashdance()
Then, remove one inet_twsk_put() by setting tw_refcnt to 3 instead
of 4, but adding a fat warning that we do not have the right to access
tw anymore after inet_twsk_hashdance()
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/dccp/minisocks.c')
| -rw-r--r-- | net/dccp/minisocks.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/net/dccp/minisocks.c b/net/dccp/minisocks.c index 178bb9833311..37ccbe62eb1a 100644 --- a/net/dccp/minisocks.c +++ b/net/dccp/minisocks.c @@ -63,9 +63,10 @@ void dccp_time_wait(struct sock *sk, int state, int timeo) */ local_bh_disable(); inet_twsk_schedule(tw, timeo); - /* Linkage updates. */ - __inet_twsk_hashdance(tw, sk, &dccp_hashinfo); - inet_twsk_put(tw); + /* Linkage updates. + * Note that access to tw after this point is illegal. + */ + inet_twsk_hashdance(tw, sk, &dccp_hashinfo); local_bh_enable(); } else { /* Sorry, if we're out of memory, just CLOSE this |