diff options
author | Serhey Popovych <serhe.popovych@gmail.com> | 2017-06-20 13:29:25 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2017-06-20 15:34:02 -0400 |
commit | 07f615574f8ac499875b21c1142f26308234a92c (patch) | |
tree | 9b01c1d01c47a7a48ad18063217bb6ebd3fa68cb /net/core | |
parent | 7e113321eccba2b52c0e9d11129d370c9511e4db (diff) | |
download | linux-07f615574f8ac499875b21c1142f26308234a92c.tar.bz2 |
ipv6: Do not leak throw route references
While commit 73ba57bfae4a ("ipv6: fix backtracking for throw routes")
does good job on error propagation to the fib_rules_lookup()
in fib rules core framework that also corrects throw routes
handling, it does not solve route reference leakage problem
happened when we return -EAGAIN to the fib_rules_lookup()
and leave routing table entry referenced in arg->result.
If rule with matched throw route isn't last matched in the
list we overwrite arg->result losing reference on throw
route stored previously forever.
We also partially revert commit ab997ad40839 ("ipv6: fix the
incorrect return value of throw route") since we never return
routing table entry with dst.error == -EAGAIN when
CONFIG_IPV6_MULTIPLE_TABLES is on. Also there is no point
to check for RTF_REJECT flag since it is always set throw
route.
Fixes: 73ba57bfae4a ("ipv6: fix backtracking for throw routes")
Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core')
0 files changed, 0 insertions, 0 deletions