diff options
author | Florian Westphal <fw@strlen.de> | 2017-12-01 00:21:04 +0100 |
---|---|---|
committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2018-01-08 18:01:07 +0100 |
commit | 8c873e2199700c2de7dbd5eedb9d90d5f109462b (patch) | |
tree | 7c7a2d4d7853659a19a36a725767871351a7aedf /net/bridge | |
parent | 26888dfd7e7454686b8d3ea9ba5045d5f236e4d7 (diff) | |
download | linux-8c873e2199700c2de7dbd5eedb9d90d5f109462b.tar.bz2 |
netfilter: core: free hooks with call_rcu
Giuseppe Scrivano says:
"SELinux, if enabled, registers for each new network namespace 6
netfilter hooks."
Cost for this is high. With synchronize_net() removed:
"The net benefit on an SMP machine with two cores is that creating a
new network namespace takes -40% of the original time."
This patch replaces synchronize_net+kvfree with call_rcu().
We store rcu_head at the tail of a structure that has no fixed layout,
i.e. we cannot use offsetof() to compute the start of the original
allocation. Thus store this information right after the rcu head.
We could simplify this by just placing the rcu_head at the start
of struct nf_hook_entries. However, this structure is used in
packet processing hotpath, so only place what is needed for that
at the beginning of the struct.
Reported-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'net/bridge')
0 files changed, 0 insertions, 0 deletions