diff options
| author | Sven Eckelmann <sven@narfation.org> | 2019-11-25 10:46:50 +0100 |
|---|---|---|
| committer | Simon Wunderlich <sw@simonwunderlich.de> | 2020-05-26 09:23:33 +0200 |
| commit | 9ad346c90509ebd983f60da7d082f261ad329507 (patch) | |
| tree | 6f2f61ebedfe95a733e072907ec87d440f0bd6eb /net/batman-adv/trace.h | |
| parent | cf78bb0bbcef3fbe1abf118f14b81dad36eaa94e (diff) | |
| download | linux-9ad346c90509ebd983f60da7d082f261ad329507.tar.bz2 | |
batman-adv: Revert "disable ethtool link speed detection when auto negotiation off"
The commit 8c46fcd78308 ("batman-adv: disable ethtool link speed detection
when auto negotiation off") disabled the usage of ethtool's link_ksetting
when auto negotation was enabled due to invalid values when used with
tun/tap virtual net_devices. According to the patch, automatic measurements
should be used for these kind of interfaces.
But there are major flaws with this argumentation:
* automatic measurements are not implemented
* auto negotiation has nothing to do with the validity of the retrieved
values
The first point has to be fixed by a longer patch series. The "validity"
part of the second point must be addressed in the same patch series by
dropping the usage of ethtool's link_ksetting (thus always doing automatic
measurements over ethernet).
Drop the patch again to have more default values for various net_device
types/configurations. The user can still overwrite them using the
batadv_hardif's BATADV_ATTR_THROUGHPUT_OVERRIDE.
Reported-by: Matthias Schiffer <mschiffer@universe-factory.net>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Diffstat (limited to 'net/batman-adv/trace.h')
0 files changed, 0 insertions, 0 deletions