diff options
author | Antonio Quartulli <ordex@autistici.org> | 2011-10-05 17:05:25 +0200 |
---|---|---|
committer | Sven Eckelmann <sven@narfation.org> | 2011-11-20 13:08:33 +0100 |
commit | c90681b8505946761b55d4981c9c3b56b3c4171b (patch) | |
tree | b260388317b5dc1f4a8c00493eea6ff30fb47652 /net/batman-adv/originator.h | |
parent | eb7e2a1e20488f91c7007caa080b83b8e4222572 (diff) | |
download | linux-c90681b8505946761b55d4981c9c3b56b3c4171b.tar.bz2 |
batman-adv: fixed hash functions type to uint32_t instead of int
There are two reasons for this fix:
- the result of choose_orig() and vis_choose() is an index and therefore it can't
be negative. Hence it is correct to make the return type unsigned too.
- sizeof(int) may not be the same on ALL the architectures. Since we plan to use
choose_orig() as DHT hash function, we need to guarantee that, given the same
argument, the result is the same. Then it is correct to explicitly express
the size of the return type (and the second argument). Since the expected
length is currently 4, uint32_t is the most convenient choice.
Signed-off-by: Antonio Quartulli <ordex@autistici.org>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Diffstat (limited to 'net/batman-adv/originator.h')
-rw-r--r-- | net/batman-adv/originator.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/batman-adv/originator.h b/net/batman-adv/originator.h index cfc1f60a96a1..67765ffef731 100644 --- a/net/batman-adv/originator.h +++ b/net/batman-adv/originator.h @@ -42,7 +42,7 @@ int orig_hash_del_if(struct hard_iface *hard_iface, int max_if_num); /* hashfunction to choose an entry in a hash table of given size */ /* hash algorithm from http://en.wikipedia.org/wiki/Hash_table */ -static inline int choose_orig(const void *data, int32_t size) +static inline uint32_t choose_orig(const void *data, uint32_t size) { const unsigned char *key = data; uint32_t hash = 0; |