summaryrefslogtreecommitdiffstats
path: root/net/802
diff options
context:
space:
mode:
authorDavid Woodhouse <dwmw2@infradead.org>2012-04-08 09:55:43 +0000
committerDavid S. Miller <davem@davemloft.net>2012-04-13 13:03:45 -0400
commit9d02daf754238adac48fa075ee79e7edd3d79ed3 (patch)
tree6edff9e75f53762ef0c201a9ae8e871a050dc07a /net/802
parent39abbaef19cd0a30be93794aa4773c779c3eb1f3 (diff)
downloadlinux-9d02daf754238adac48fa075ee79e7edd3d79ed3.tar.bz2
pppoatm: Fix excessive queue bloat
We discovered that PPPoATM has an excessively deep transmit queue. A queue the size of the default socket send buffer (wmem_default) is maintained between the PPP generic core and the ATM device. Fix it to queue a maximum of *two* packets. The one the ATM device is currently working on, and one more for the ATM driver to process immediately in its TX done interrupt handler. The PPP core is designed to feed packets to the channel with minimal latency, so that really ought to be enough to keep the ATM device busy. While we're at it, fix the fact that we were triggering the wakeup tasklet on *every* pppoatm_pop() call. The comment saying "this is inefficient, but doing it right is too hard" turns out to be overly pessimistic... I think :) On machines like the Traverse Geos, with a slow Geode CPU and two high-speed ADSL2+ interfaces, there were reports of extremely high CPU usage which could partly be attributed to the extra wakeups. (The wakeup handling could actually be made a whole lot easier if we stop checking sk->sk_sndbuf altogether. Given that we now only queue *two* packets ever, one wonders what the point is. As it is, you could already deadlock the thing by setting the sk_sndbuf to a value lower than the MTU of the device, and it'd just block for ever.) Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/802')
0 files changed, 0 insertions, 0 deletions